refactor decompression logic to use output buffer size (not capacity) + 2x output size on LIBDEFLATE_INSUFFICIENT_SPACE + removed LIBDEFLATE_SHORT_OUTPUT case as we're always passing non NULL actual_size [publish binary]

Author: artemp

src/deflate.hpp

@@ -141,31 +141,25 @@ class Decompressor
                          size,
                          const_cast<char*>(output.data()),
                          output.size(), &actual_size);
-            if (result != LIBDEFLATE_INSUFFICIENT_SPACE)
+            if (result == LIBDEFLATE_SUCCESS)
             {
+                output.resize(actual_size);
                 break;
             }
-            if (output.size() == max_)
+            else if (result == LIBDEFLATE_INSUFFICIENT_SPACE)
             {
-                throw std::runtime_error("request to resize output buffer can't exceed maximum limit");
+                if (output.size() == max_)
+                {
+                    throw std::runtime_error("request to resize output buffer can't exceed maximum limit");
+                }
+                std::size_t new_size = std::min(output.size() << 1, max_);
+                output.resize(new_size);
+            }
+            else //LIBDEFLATE_BAD_DATA
+            {
+                throw std::runtime_error("bad data: did not succeed");
             }
-            std::size_t new_size = std::min((output.capacity() << 1) - output.size(), max_);
-            output.resize(new_size);
-        }
-
-        if (result == LIBDEFLATE_SHORT_OUTPUT)
-        {
-            throw std::runtime_error("short output: did not succeed");
-        }
-        else if (result == LIBDEFLATE_BAD_DATA)
-        {
-            throw std::runtime_error("bad data: did not succeed");
-        }
-        else if (result != LIBDEFLATE_SUCCESS)
-        {
-            throw std::runtime_error("did not succeed");
         }
-        output.resize(actual_size);
     }
 };
 

src/vtcomposite.hpp

@@ -3,6 +3,6 @@
 
 namespace vtile {
 
-Napi::Value composite(const Napi::CallbackInfo& info);
+Napi::Value composite(Napi::CallbackInfo const& info);
 
 } // namespace vtile