Skip to content

Commit 8f086fa

Browse files
authored
Create a new dist version 2.2.19 (iguazio#367)
Collecting: - Fix [Wizard] batch run - back/next buttons does not look like "button" (iguazio#365) - Fix [UI] "All changes will be lost" pop up appears upon artifact register / job schedule (iguazio#366)
1 parent e0b3638 commit 8f086fa

File tree

6 files changed

+31
-14
lines changed

6 files changed

+31
-14
lines changed

commit_message

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22

3-
Create a new dist version 2.2.18
3+
Create a new dist version 2.2.19
44

55
Collecting:
6-
- Fix [Jobs] Table row render issue (#363)
7-
- Fix [Artifacts] special characters in artifact label value should be considered legit (#362)
6+
- Fix [Wizard] batch run - back/next buttons does not look like "button" (#365)
7+
- Fix [UI] "All changes will be lost" pop up appears upon artifact register / job schedule (#366)

dist/components/Button/Button.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ const Button = /*#__PURE__*/(0, _react.forwardRef)((_ref, ref) => {
3838
className = '',
3939
density = 'normal',
4040
icon,
41+
iconPosition = 'left',
4142
id = 'btn',
4243
label = 'Button',
4344
tooltip = '',
@@ -50,16 +51,16 @@ const Button = /*#__PURE__*/(0, _react.forwardRef)((_ref, ref) => {
5051
className: buttonClassName,
5152
ref: ref,
5253
"data-testid": id,
53-
children: [icon, tooltip ? /*#__PURE__*/(0, _jsxRuntime.jsx)(_Tooltip.default, {
54+
children: [icon && iconPosition === 'left' && icon, tooltip ? /*#__PURE__*/(0, _jsxRuntime.jsx)(_Tooltip.default, {
5455
template: /*#__PURE__*/(0, _jsxRuntime.jsx)(_TextTooltipTemplate.default, {
5556
text: tooltip
5657
}),
57-
children: label && /*#__PURE__*/(0, _jsxRuntime.jsx)("div", {
58+
children: label && /*#__PURE__*/(0, _jsxRuntime.jsx)("span", {
5859
children: label
5960
})
60-
}) : label && /*#__PURE__*/(0, _jsxRuntime.jsx)("div", {
61+
}) : label && /*#__PURE__*/(0, _jsxRuntime.jsx)("span", {
6162
children: label
62-
})]
63+
}), icon && iconPosition === 'right' && icon]
6364
});
6465
});
6566
Button.propTypes = {

dist/components/FormChipCell/FormChipCell.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,6 @@ const FormChipCell = _ref => {
8282
isValueFocused: false,
8383
isNewChip: false
8484
});
85-
(0, _react.useEffect)(() => {
86-
formState.form.change('labelsAreInEditMode', editConfig.isEdit);
87-
}, [editConfig.isEdit, formState.form]);
8885
let chips = (0, _react.useMemo)(() => {
8986
return isEditable || visibleChipsMaxLength === 'all' ? {
9087
visibleChips: (0, _lodash.get)(formState.values, name),

dist/components/Wizard/Wizard.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ var _Modal = _interopRequireDefault(require("../Modal/Modal"));
1313
var _WizardSteps = _interopRequireDefault(require("./WizardSteps/WizardSteps"));
1414
var _constants = require("../../constants");
1515
var _types = require("../../types");
16+
var _backArrow = require("../../images/back-arrow.svg");
1617
require("./Wizard.scss");
1718
var _jsxRuntime = require("react/jsx-runtime");
1819
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
@@ -107,20 +108,25 @@ const Wizard = _ref => {
107108
if (activeStepNumber !== 0) {
108109
defaultActions.push( /*#__PURE__*/(0, _jsxRuntime.jsx)(_Button.default, {
109110
id: "wizard-btn-back",
111+
icon: /*#__PURE__*/(0, _jsxRuntime.jsx)(_backArrow.ReactComponent, {}),
112+
className: "wizard-form__back-button",
110113
onClick: goToPreviousStep,
111114
disabled: activeStepNumber === 0,
112115
label: "Back",
113116
type: "button",
114-
variant: _constants.LABEL_BUTTON
117+
variant: _constants.TERTIARY_BUTTON
115118
}));
116119
}
117120
defaultActions.push( /*#__PURE__*/(0, _jsxRuntime.jsx)(_Button.default, {
118121
id: "wizard-btn-next",
122+
icon: /*#__PURE__*/(0, _jsxRuntime.jsx)(_backArrow.ReactComponent, {}),
123+
iconPosition: "right",
124+
className: "wizard-form__next-button",
119125
disabled: (stepConfig === null || stepConfig === void 0 ? void 0 : stepConfig.nextIsDisabled) || isLastStep,
120126
onClick: goToNextStep,
121-
label: 'Next',
127+
label: "Next",
122128
type: "button",
123-
variant: _constants.LABEL_BUTTON
129+
variant: _constants.TERTIARY_BUTTON
124130
}));
125131
return defaultActions;
126132
};

dist/components/Wizard/Wizard.scss

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,17 @@
3737
height: 100%;
3838
}
3939
}
40+
41+
&__back-button,
42+
&__next-button {
43+
svg {
44+
width: 14px;
45+
}
46+
}
47+
48+
&__next-button {
49+
svg {
50+
rotate: 180deg;
51+
}
52+
}
4053
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "iguazio.dashboard-react-controls",
3-
"version": "2.2.18",
3+
"version": "2.2.19",
44
"description": "Collection of resources (such as CSS styles, fonts and images) and ReactJS 17.x components to share among different Iguazio React repos.",
55
"main": "dist/index.js",
66
"module": "dist/index.js",

0 commit comments

Comments
 (0)