starlark/types: validate function and CallStack reccord

Author: mcuadros

starlark/types/backend.go

@@ -53,7 +53,7 @@ func MakeBackend(
 	}
 
 	pm := t.Local(PluginManagerLocal).(*terraform.PluginManager)
-	p, err := NewBackend(pm, name.GoString())
+	p, err := NewBackend(pm, name.GoString(), t.CallStack())
 	if err != nil {
 		return nil, err
 	}
@@ -101,7 +101,7 @@ var _ starlark.HasAttrs = &Backend{}
 var _ starlark.Comparable = &Backend{}
 
 // NewBackend returns a new Backend instance based on given arguments,
-func NewBackend(pm *terraform.PluginManager, typ string) (*Backend, error) {
+func NewBackend(pm *terraform.PluginManager, typ string, cs starlark.CallStack) (*Backend, error) {
 	fn := binit.Backend(typ)
 	if fn == nil {
 		return nil, fmt.Errorf("unable to find backend %q", typ)
@@ -112,7 +112,7 @@ func NewBackend(pm *terraform.PluginManager, typ string) (*Backend, error) {
 	return &Backend{
 		pm:       pm,
 		b:        b,
-		Resource: NewResource("", typ, BackendKind, b.ConfigSchema(), nil, nil),
+		Resource: NewResource("", typ, BackendKind, b.ConfigSchema(), nil, nil, cs),
 	}, nil
 }
 
@@ -261,7 +261,7 @@ func (s *State) initialize(state *states.State, mod *states.Module) error {
 	addrs := state.ProviderAddrs()
 	for _, addr := range addrs {
 		typ := addr.ProviderConfig.Type.Type
-		p, err := NewProvider(s.pm, typ, "", addr.ProviderConfig.Alias)
+		p, err := NewProvider(s.pm, typ, "", addr.ProviderConfig.Alias, nil)
 		if err != nil {
 			return err
 		}
@@ -297,7 +297,7 @@ func (s *State) initializeResource(p *Provider, r *states.Resource) error {
 
 	multi := r.EachMode != states.NoEach
 	for _, instance := range r.Instances {
-		r := NewResource(name, typ, ResourceKind, schema.Block, p, p.Resource)
+		r := NewResource(name, typ, ResourceKind, schema.Block, p, p.Resource, nil)
 
 		var val interface{}
 		if err := json.Unmarshal(instance.Current.AttrsJSON, &val); err != nil {

starlark/types/collection.go

@@ -55,11 +55,13 @@ import (
 //                 Value to match in the given key.
 //
 type ResourceCollection struct {
-	typ      string
-	kind     Kind
-	block    *configschema.Block
-	provider *Provider
-	parent   *Resource
+	typ         string
+	kind        Kind
+	block       *configschema.Block
+	nestedblock *configschema.NestedBlock
+	provider    *Provider
+	parent      *Resource
+
 	*starlark.List
 }
 
@@ -82,6 +84,21 @@ func NewResourceCollection(
 	}
 }
 
+// NewNestedResourceCollection returns
+func NewNestedResourceCollection(
+	typ string, block *configschema.NestedBlock, provider *Provider, parent *Resource,
+) *ResourceCollection {
+	return &ResourceCollection{
+		typ:         typ,
+		kind:        NestedKind,
+		block:       &block.Block,
+		nestedblock: block,
+		provider:    provider,
+		parent:      parent,
+		List:        starlark.NewList(nil),
+	}
+}
+
 // LoadList loads a list of dicts on the collection. It clears the collection.
 func (c *ResourceCollection) LoadList(l *starlark.List) error {
 	if err := c.List.Clear(); err != nil {
@@ -94,7 +111,7 @@ func (c *ResourceCollection) LoadList(l *starlark.List) error {
 			return fmt.Errorf("%d: expected dict, got %s", i, l.Index(i).Type())
 		}
 
-		r := NewResource("", c.typ, c.kind, c.block, c.provider, c.parent)
+		r := NewResource("", c.typ, c.kind, c.block, c.provider, c.parent, nil)
 		if dict != nil && dict.Len() != 0 {
 			if err := r.loadDict(dict); err != nil {
 				return err

starlark/types/provider.go

@@ -50,7 +50,7 @@ func MakeProvider(
 	}
 
 	pm := t.Local(PluginManagerLocal).(*terraform.PluginManager)
-	p, err := NewProvider(pm, name.GoString(), version.GoString(), alias.GoString())
+	p, err := NewProvider(pm, name.GoString(), version.GoString(), alias.GoString(), t.CallStack())
 	if err != nil {
 		return nil, err
 	}
@@ -112,7 +112,7 @@ var _ starlark.HasAttrs = &Provider{}
 var _ starlark.Comparable = &Provider{}
 
 // NewProvider returns a new Provider instance from a given type, version and name.
-func NewProvider(pm *terraform.PluginManager, typ, version, name string) (*Provider, error) {
+func NewProvider(pm *terraform.PluginManager, typ, version, name string, cs starlark.CallStack) (*Provider, error) {
 	cli, meta, err := pm.Provider(typ, version, false)
 	if err != nil {
 		return nil, err
@@ -141,7 +141,7 @@ func NewProvider(pm *terraform.PluginManager, typ, version, name string) (*Provi
 		meta:     meta,
 	}
 
-	p.Resource = NewResource(name, typ, ProviderKind, response.Provider.Block, p, nil)
+	p.Resource = NewResource(name, typ, ProviderKind, response.Provider.Block, p, nil, cs)
 	p.dataSources = NewResourceCollectionGroup(p, DataSourceKind, response.DataSources)
 	p.resources = NewResourceCollectionGroup(p, ResourceKind, response.ResourceTypes)
 

starlark/types/provider_test.go

@@ -81,6 +81,7 @@ func doTestPrint(t *testing.T, filename string, print func(*starlark.Thread, str
 		"hcl":         BuiltinHCL(),
 		"fn":          BuiltinFunctionAttribute(),
 		"evaluate":    BuiltinEvaluate(),
+		"validate":    BuiltinValidate(),
 		"tf":          NewTerraform(pm),
 	}
 

starlark/types/provisioner.go

@@ -44,7 +44,7 @@ func MakeProvisioner(
 		return nil, fmt.Errorf("unexpected positional arguments count")
 	}
 
-	p, err := NewProvisioner(pm, name.GoString())
+	p, err := NewProvisioner(pm, name.GoString(), t.CallStack())
 	if err != nil {
 		return nil, err
 	}
@@ -79,7 +79,7 @@ type Provisioner struct {
 }
 
 // NewProvisioner returns a new Provisioner for the given type.
-func NewProvisioner(pm *terraform.PluginManager, typ string) (*Provisioner, error) {
+func NewProvisioner(pm *terraform.PluginManager, typ string, cs starlark.CallStack) (*Provisioner, error) {
 	cli, meta, err := pm.Provisioner(typ)
 	if err != nil {
 		return nil, err
@@ -103,7 +103,7 @@ func NewProvisioner(pm *terraform.PluginManager, typ string) (*Provisioner, erro
 		provisioner: provisioner,
 		meta:        meta,
 
-		Resource: NewResource(NameGenerator(), typ, ProvisionerKind, response.Provisioner, nil, nil),
+		Resource: NewResource(NameGenerator(), typ, ProvisionerKind, response.Provisioner, nil, nil, cs),
 	}, nil
 }
 

starlark/types/resource.go

@@ -20,7 +20,7 @@ var NameGenerator = func() string {
 	return fmt.Sprintf("id_%s", ulid.MustNew(ulid.Timestamp(t), entropy))
 }
 
-// Kind describes what kind of resource is represented by a Resource isntance.
+// Kind describes what kind of resource is represented by a Resource instance.
 type Kind string
 
 // IsNamed returns true if this kind of resources contains a name.
@@ -65,7 +65,7 @@ func MakeResource(
 		name = NameGenerator()
 	}
 
-	r := NewResource(name, c.typ, c.kind, c.block, c.provider, c.parent)
+	r := NewResource(name, c.typ, c.kind, c.block, c.provider, c.parent, t.CallStack())
 	if dict != nil && dict.Len() != 0 {
 		if err := r.loadDict(dict); err != nil {
 			return nil, err
@@ -208,6 +208,8 @@ type Resource struct {
 	parent       *Resource
 	dependencies []*Resource
 	provisioners []*Provisioner
+
+	cs starlark.CallStack
 }
 
 var _ starlark.Value = &Resource{}
@@ -217,7 +219,11 @@ var _ starlark.Comparable = &Resource{}
 
 // NewResource returns a new resource of the given kind, type based on the
 // given configschema.Block.
-func NewResource(name, typ string, k Kind, b *configschema.Block, provider *Provider, parent *Resource) *Resource {
+func NewResource(
+	name, typ string, k Kind,
+	b *configschema.Block, provider *Provider, parent *Resource,
+	cs starlark.CallStack,
+) *Resource {
 	return &Resource{
 		name:     name,
 		typ:      typ,
@@ -226,6 +232,7 @@ func NewResource(name, typ string, k Kind, b *configschema.Block, provider *Prov
 		values:   NewValues(),
 		provider: provider,
 		parent:   parent,
+		cs:       cs,
 	}
 }
 
@@ -337,11 +344,14 @@ func (r *Resource) attrBlock(name string, b *configschema.NestedBlock) (starlark
 		return v.Starlark(), nil
 	}
 
+	var output starlark.Value
 	if b.MaxItems != 1 {
-		return r.values.Set(name, MustValue(NewResourceCollection(name, NestedKind, &b.Block, r.provider, r))).Starlark(), nil
+		output = NewNestedResourceCollection(name, b, r.provider, r)
+	} else {
+		output = NewResource("", name, NestedKind, &b.Block, r.provider, r, nil)
 	}
 
-	return r.values.Set(name, MustValue(NewResource("", name, NestedKind, &b.Block, r.provider, r))).Starlark(), nil
+	return r.values.Set(name, MustValue(output)).Starlark(), nil
 }
 
 func (r *Resource) attrValue(name string, attr *configschema.Attribute) (starlark.Value, error) {
@@ -559,3 +569,15 @@ func (r *Resource) doCompareSameType(y *Resource, depth int) (bool, error) {
 
 	return true, nil
 }
+
+func (r *Resource) CallStack() starlark.CallStack {
+	if r.cs != nil {
+		return r.cs
+	}
+
+	if r.parent != nil {
+		return r.parent.CallStack()
+	}
+
+	return nil
+}

starlark/types/testdata/validate.star

@@ -0,0 +1,29 @@
+load("assert.star", "assert")
+
+helm = tf.provider("helm", "1.0.0", "default")
+helm.kubernetes.token = "foo"
+
+# require scalar arguments
+helm.resource.release()
+errors = validate(helm)
+assert.eq(len(errors), 2)
+assert.eq(errors[0].pos, "testdata/validate.star:7:22")
+assert.eq(errors[1].pos, "testdata/validate.star:7:22")
+
+# require list arguments
+google = tf.provider("google")
+r = google.resource.organization_iam_custom_role(role_id="foo", org_id="bar", title="qux")
+r.permissions = ["foo"]
+assert.eq(len(validate(google)), 0)
+
+r.permissions.pop()
+assert.eq(len(validate(google)), 1)
+
+# require blocks
+google = tf.provider("google")
+r = google.resource.compute_global_forwarding_rule(target="foo", name="bar")
+r.metadata_filters()
+assert.eq(len(validate(google)), 2)
+
+errors = validate(google)
+for e in errors: print(e.pos, e.msg)