Resolve review findings

Author: NikolaSimsic

.github/actions/start-runtime/action.yml

@@ -19,7 +19,7 @@ runs:
       shell: bash
     - name: "Setup Java 21"
       id: setup-java
-      uses: actions/setup-java@v4
+      uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 #v4
       with:
         distribution: "temurin"
         java-version: "21"

.github/workflows/NativeAutomatedTestsAndroid.yml

@@ -20,7 +20,7 @@ jobs:
     steps:
       #     - name: "Checking changed files"
       #       id: files
-      #       uses: softprops/diffset@v1
+      #       uses: softprops/diffset@d5947696689a571f7a984a52505e2649eead5c22 # v1
       #       if:
       #           github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name ==
       #           github.repository

.github/workflows/NativePipeline.yml

@@ -74,7 +74,7 @@ jobs:
       widgets: ${{ steps.scope.outputs.widgets }}
     steps:
       - name: "Check out code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
 
       - name: "Determine scope"
         id: scope
@@ -121,7 +121,7 @@ jobs:
       mendix_version: ${{ steps.set-mendix-version.outputs.MENDIX_VERSION }}
     steps:
       - name: "Check out code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
       - name: "Get Mendix version from JSON"
         id: get-mendix-version
         uses: notiz-dev/github-action-json-property@7a701887f4b568b23eb7b78bb0fc49aaeb1b68d3 # v0.2.0
@@ -155,7 +155,7 @@ jobs:
           docker manifest inspect ghcr.io/mendix/native-widgets/mxbuild:${{ needs.mendix-version.outputs.mendix_version }} || EXIT_CODE=$?
           echo "IMAGE_MISSING=$EXIT_CODE" >> $GITHUB_ENV
       - name: "Check out code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         if: ${{ env.IMAGE_MISSING != 0 }}
       - name: "Build mxbuild image"
         if: ${{ env.IMAGE_MISSING != 0 }}
@@ -175,11 +175,11 @@ jobs:
       contents: read
     steps:
       - name: "Check out code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         with:
           fetch-depth: 0
       - name: "Set up node"
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4
         with:
           node-version-file: .nvmrc
           cache: yarn
@@ -195,7 +195,7 @@ jobs:
         env:
           NODE_OPTIONS: --max_old_space_size=6144
       - name: "Upload resources artifact"
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 #v4
         with:
           name: resources
           path: |
@@ -254,7 +254,7 @@ jobs:
         run: |
           mxbuild -o automation.mda --loose-version-check Native-Mobile-Resources-main/NativeComponentsTestProject.mpr
       - name: "Upload MDA"
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 #v4
         with:
           name: mda
           path: automation.mda
@@ -268,7 +268,7 @@ jobs:
         password: ${{ secrets.GITHUB_TOKEN }}
     steps:
       - name: "Check out code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
       - name: "Download deployment package"
         uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7
         with:
@@ -288,7 +288,7 @@ jobs:
         password: ${{ secrets.GITHUB_TOKEN }}
     steps:
       - name: "Check out code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
       - name: "Download project MDA file"
         uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7
         with:
@@ -303,13 +303,13 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: "Check out Native Template for Native Components Test Project"
-        uses: actions/checkout@v4
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         with:
           repository: mendix/native-template
           ref: ${{ github.event.inputs.nt_branch || 'master' }}
           path: native-template
       - name: "Check out code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         with:
           path: native-widgets
       - name: "Download Android bundle and assets"
@@ -318,13 +318,13 @@ jobs:
           name: android-bundle
           path: bundles/android
       - name: "Set up Node"
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4
         with:
           node-version-file: native-template/.nvmrc
           cache: npm
           cache-dependency-path: native-template/package-lock.json
       - name: "Cache Android Build"
-        uses: actions/cache@v3
+        uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4
         with:
           path: native-template/android/app/build
           key: ${{ runner.os }}-android-build-${{ hashFiles('native-template/android/app/src/**/*.java', 'native-template/android/app/src/**/*.kt', 'native-template/android/app/build.gradle') }}
@@ -341,7 +341,7 @@ jobs:
         working-directory: native-template
         run: npm i
       - name: "Setup JDK "
-        uses: actions/setup-java@v4
+        uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 #v4
         with:
           java-version: 21
           distribution: temurin
@@ -360,7 +360,7 @@ jobs:
           echo "Listing APK files in the output directory:"
           ls -R native-template/android/app/build/outputs/apk/
       - name: "Archive Android app"
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 #v4
         with:
           name: android-app
           path: native-template/android/app/build/outputs/apk/**/*.apk
@@ -369,13 +369,13 @@ jobs:
     runs-on: macos-13
     steps:
       - name: "Check out Native Template for Native Components Test Project"
-        uses: actions/checkout@v4
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         with:
           repository: mendix/native-template
           ref: ${{ github.event.inputs.nt_branch || 'master' }}
           path: native-template
       - name: "Check out code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         with:
           path: native-widgets
       - name: "Download iOS bundle and assets"
@@ -384,13 +384,13 @@ jobs:
           name: ios-bundle
           path: bundles/ios
       - name: "Set up Node"
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4
         with:
           node-version-file: native-template/.nvmrc
           cache: npm
           cache-dependency-path: native-template/package-lock.json
       - name: "Cache iOS Build"
-        uses: actions/cache@v3
+        uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4
         with:
           path: native-template/ios/build
           key: ${{ runner.os }}-ios-build-${{ hashFiles('native-template/ios/**/*.swift', 'native-template/ios/**/*.h', 'native-template/ios/Podfile.lock') }}
@@ -407,7 +407,7 @@ jobs:
         run: npm i
 
       - name: "Setup Pods cache"
-        uses: actions/cache@v3
+        uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4
         with:
           path: native-template/Pods
           key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock') }}
@@ -420,7 +420,7 @@ jobs:
         working-directory: native-template/ios
         run: xcodebuild -workspace NativeTemplate.xcworkspace -scheme nativeTemplate -configuration Debug -sdk iphonesimulator -derivedDataPath build ONLY_ACTIVE_ARCH=YES VALID_ARCHS="i386 x86_64"
       - name: "Archive iOS app"
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 #v4
         with:
           name: ios-app
           path: native-template/ios/build/Build/Products/**/*.app
@@ -434,18 +434,18 @@ jobs:
       fail-fast: false
     steps:
       - name: "Check out code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         with:
           fetch-depth: 0
       - name: "Set up node"
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4
         with:
           node-version-file: .nvmrc
           cache: yarn
       - name: "Install dependencies"
         run: yarn install --immutable
       - name: "Download project MDA file"
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7
         with:
           name: mda
 
@@ -478,7 +478,7 @@ jobs:
       #     unzip android-app.zip -d android-app
 
       - name: "Download Android app"
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7
         with:
           name: android-app
           path: android-app
@@ -507,7 +507,7 @@ jobs:
           sudo udevadm control --reload-rules
           sudo udevadm trigger --name-match=kvm
       - name: "Run the android tests"
-        uses: reactivecircus/android-emulator-runner@v2.32.0
+        uses: reactivecircus/android-emulator-runner@62dbb605bba737720e10b196cb4220d374026a6d # v2.0.0
         with:
           api-level: 30
           target: google_apis
@@ -522,21 +522,21 @@ jobs:
             bash maestro/run_maestro_tests.sh android "${{ matrix.widget }}"
       
       - name: "Archive runtime logs"
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 #v4
         if: always()
         with:
           name: android-runtime-logs-${{ matrix.widget }}
           path: log/*.log
           if-no-files-found: ignore
       - name: "Archive test screenshots"
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 #v4
         if: always()
         with:
           name: android-screenshots-${{ matrix.widget }}
           path: ${{ github.workspace }}/maestro/images/actual/android/**/*.png
           if-no-files-found: ignore
       - name: "Archive artifacts"
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 #v4
         if: always()
         with:
           name: android-artifacts-${{ matrix.widget }}
@@ -552,11 +552,11 @@ jobs:
       fail-fast: false
     steps:
       - name: "Check out code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         with:
           fetch-depth: 0
       - name: "Set up node"
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4
         with:
           node-version-file: .nvmrc
           cache: yarn
@@ -565,7 +565,7 @@ jobs:
           yarn cache clean
           yarn install --immutable
       - name: "Download project MDA file"
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7
         with:
           name: mda
 
@@ -637,21 +637,21 @@ jobs:
           bash maestro/run_maestro_tests.sh ios "${{ matrix.widget }}"
       
       - name: "Archive runtime logs"
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 #v4
         if: always()
         with:
           name: ios-runtime-logs-${{ matrix.widget }}
           path: log/*.log
           if-no-files-found: ignore
       - name: "Archive test screenshots"
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 #v4
         if: always()
         with:
           name: ios-screenshots-${{ matrix.widget }}
           path: ${{ github.workspace }}/maestro/images/actual/ios/**/*.png
           if-no-files-found: ignore
       - name: "Archive artifacts"
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 #v4
         if: always()
         with:
           name: ios-artifacts-${{ matrix.widget }}
@@ -666,7 +666,7 @@ jobs:
       GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     steps:
       - name: "Check out code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
 
       - name: "Download Android screenshots"
         run: |
@@ -688,7 +688,7 @@ jobs:
 
     
       - name: "Set up node"
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4
         with:
           node-version-file: .nvmrc
           cache: yarn
@@ -705,14 +705,14 @@ jobs:
         run: node ${{ github.workspace }}/maestro/helpers/compare_screenshots.js ios
 
       - name: "Archive diff results"
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 #v4
         with:
           name: screenshot-diffs
           path: images/diffs
           if-no-files-found: ignore
 
       - name: "Archive comparison results"
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 #v4
         with:
           name: comparison-results
           path: compare_output.txt

maestro/helpers/prepare_ios.sh

@@ -1,40 +1,28 @@
 #!/bin/bash
 
-# Function to start the iOS simulator
 start_simulator() {
     echo "Starting iOS Simulator..."
     xcrun simctl boot "iPhone 16" || echo "Simulator already booted"
     sleep 30
     xcrun simctl bootstatus || echo "Simulator booted successfully"
 }
 
-# Function to set the status bar on the iOS simulator
 set_status_bar() {
     echo "Setting status bar on iOS Simulator..."
     xcrun simctl status_bar "iPhone 16" override --time "11:01" --wifiBars 3 --cellularBars 4 --batteryState charged --batteryLevel 100
 }
 
-# Function to install the iOS app on the simulator
 install_ios_app() {
     echo "Installing iOS app on simulator..."
     xcrun simctl install booted ios-app/Debug-iphonesimulator/NativeTemplate.app
 }
 
-# Function to verify the installed app
 verify_installed_app() {
     echo "Verifying installed app..."
     xcrun simctl get_app_container booted com.mendix.native.template
 }
 
-# Function to launch the iOS app
-# launch_ios_app() {
-#     echo "Launching iOS app..."
-#     xcrun simctl launch booted com.mendix.native.template
-# }
-
-# Prepare the iOS simulator and install the app
 start_simulator
 set_status_bar
 install_ios_app
-verify_installed_app
-# launch_ios_app
+verify_installed_app

maestro/images/expected/android/line_chart.png

@@ -7,7 +7,3 @@ appId: "${APP_ID}"
     text: "Activity indicator"
 - assertVisible:
     text: "Default"
-# - assertVisible:
-#     id: "activityIndicatorDefault"
-# - takeScreenshot:
-#     path: "maestro/images/actual/${PLATFORM}/activity_indicator"