Skip to content

Commit 3adb85c

Browse files
feat(datagrid-web): add show prop to RefreshIndicator and update usage in Widget component
1 parent 0b0566c commit 3adb85c

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid.scss

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -432,6 +432,10 @@ $root: ".widget-datagrid";
432432
&-refresh-container {
433433
grid-column: 1 / -1;
434434
padding: 0;
435+
436+
&--hidden {
437+
display: none;
438+
}
435439
}
436440

437441
&-refresh-indicator {
@@ -444,6 +448,9 @@ $root: ".widget-datagrid";
444448
color: var(--brand-primary, $dg-brand-primary);
445449
height: 4px;
446450
width: 100%;
451+
position: absolute;
452+
left: 0;
453+
right: 0;
447454

448455
&::-webkit-progress-bar {
449456
background-color: transparent;

packages/pluggableWidgets/datagrid-web/src/components/RefreshIndicator.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
1+
import classNames from "classnames";
12
import { createElement, ReactElement } from "react";
23

3-
export function RefreshIndicator(): ReactElement {
4+
export function RefreshIndicator({ show }: { show: boolean }): ReactElement {
45
return (
56
<div className="tr" role="row">
6-
<div className="th widget-datagrid-refresh-container">
7+
<div
8+
className={classNames("th widget-datagrid-refresh-container", {
9+
"widget-datagrid-refresh-container--hidden": !show
10+
})}
11+
>
712
<progress className="widget-datagrid-refresh-indicator" />
813
</div>
914
</div>

packages/pluggableWidgets/datagrid-web/src/components/Widget.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ const Main = observer(<C extends GridColumn>(props: WidgetProps<C>): ReactElemen
195195
isLoading={props.columnsLoading}
196196
preview={props.preview}
197197
/>
198-
{showRefreshIndicator ? <RefreshIndicator /> : null}
198+
<RefreshIndicator show={showRefreshIndicator} />
199199
<GridBody
200200
isFirstLoad={props.isFirstLoad}
201201
isFetchingNextBatch={props.isFetchingNextBatch}

0 commit comments

Comments
 (0)