Skip to content

Commit 65b95f2

Browse files
feat(datagrid-web): dont show refresh indicator when resfreh timer is 1s or less
1 parent 36d84ea commit 65b95f2

File tree

4 files changed

+6
-1
lines changed

4 files changed

+6
-1
lines changed

packages/pluggableWidgets/datagrid-web/src/Datagrid.editorPreview.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ export function preview(props: DatagridPreviewProps): ReactElement {
147147
loadingType="spinner"
148148
columnsLoading={false}
149149
refreshIndicator={props.refreshIndicator}
150+
refreshInterval={props.refreshInterval ?? 0}
150151
/>
151152
);
152153
}

packages/pluggableWidgets/datagrid-web/src/Datagrid.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ const Container = observer((props: Props): ReactElement => {
124124
loadingType={props.loadingType}
125125
columnsLoading={!columnsStore.loaded}
126126
refreshIndicator={props.refreshIndicator}
127+
refreshInterval={props.refreshInterval}
127128
/>
128129
);
129130
});

packages/pluggableWidgets/datagrid-web/src/components/Widget.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ export interface WidgetProps<C extends GridColumn, T extends ObjectItem = Object
7272
loadingType: LoadingTypeEnum;
7373
columnsLoading: boolean;
7474
refreshIndicator: boolean;
75+
refreshInterval: number;
7576

7677
// Helpers
7778
cellEventsController: EventsController;
@@ -135,6 +136,7 @@ const Main = observer(<C extends GridColumn>(props: WidgetProps<C>): ReactElemen
135136
pagingPosition,
136137
preview,
137138
refreshIndicator,
139+
refreshInterval,
138140
selectActionHelper,
139141
setPage,
140142
visibleColumns
@@ -165,7 +167,7 @@ const Main = observer(<C extends GridColumn>(props: WidgetProps<C>): ReactElemen
165167

166168
const selectionEnabled = selectActionHelper.selectionType !== "None";
167169

168-
const showRefreshIndicator = refreshIndicator && props.isLoading && !props.isFirstLoad;
170+
const showRefreshIndicator = refreshIndicator && refreshInterval > 1 && props.isLoading && !props.isFirstLoad;
169171

170172
return (
171173
<Fragment>

packages/pluggableWidgets/datagrid-web/src/utils/test-utils.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ export function mockWidgetProps(): WidgetProps<GridColumn, ObjectItem> {
111111
loadingType: "spinner",
112112
columnsLoading: false,
113113
refreshIndicator: false,
114+
refreshInterval: 0,
114115
focusController: new FocusTargetController(
115116
new PositionController(),
116117
new VirtualGridLayout(1, columns.length, 10)

0 commit comments

Comments
 (0)