Skip to content

Commit 666f0e2

Browse files
refactor(datagrid-web): simplify RefreshIndicator usage
1 parent d9960c8 commit 666f0e2

File tree

3 files changed

+4
-12
lines changed

3 files changed

+4
-12
lines changed

packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid.scss

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -432,10 +432,7 @@ $root: ".widget-datagrid";
432432
&-refresh-container {
433433
grid-column: 1 / -1;
434434
padding: 0;
435-
436-
&--hidden {
437-
display: none;
438-
}
435+
position: relative;
439436
}
440437

441438
&-refresh-indicator {

packages/pluggableWidgets/datagrid-web/src/components/RefreshIndicator.tsx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,9 @@
1-
import classNames from "classnames";
21
import { createElement, ReactElement } from "react";
32

4-
export function RefreshIndicator({ show }: { show: boolean }): ReactElement {
3+
export function RefreshIndicator(): ReactElement {
54
return (
65
<div className="tr" role="row">
7-
<div
8-
className={classNames("th widget-datagrid-refresh-container", {
9-
"widget-datagrid-refresh-container--hidden": !show
10-
})}
11-
>
6+
<div className="th widget-datagrid-refresh-container">
127
<progress className="widget-datagrid-refresh-indicator" />
138
</div>
149
</div>

packages/pluggableWidgets/datagrid-web/src/components/Widget.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ const Main = observer(<C extends GridColumn>(props: WidgetProps<C>): ReactElemen
195195
isLoading={props.columnsLoading}
196196
preview={props.preview}
197197
/>
198-
<RefreshIndicator show={showRefreshIndicator} />
198+
{showRefreshIndicator ? <RefreshIndicator /> : null}
199199
<GridBody
200200
isFirstLoad={props.isFirstLoad}
201201
isFetchingNextBatch={props.isFetchingNextBatch}

0 commit comments

Comments
 (0)