Skip to content

Commit 7b0ca7a

Browse files
committed
fix: use label (not value) as label, makes more sense for SR UX
1 parent 2e8fa92 commit 7b0ca7a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/pluggableWidgets/datagrid-dropdown-filter-web/src/__tests__/__snapshots__/DatagridDropdownFilter.spec.tsx.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ exports[`Dropdown Filter with single instance with single attribute renders corr
77
aria-controls="downshift-:r0:-menu"
88
aria-expanded="false"
99
aria-haspopup="listbox"
10-
aria-label="Select"
10+
aria-label="AriaLabel"
1111
class="widget-dropdown-filter form-control variant-select filter-custom-class"
1212
data-empty="true"
1313
data-expanded="false"

packages/shared/widget-plugin-dropdown-filter/src/controls/select/Select.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export const Select = observer(function Select(props: SelectProps): React.ReactE
4141
data-empty={isEmpty ? true : undefined}
4242
style={props.style}
4343
{...getToggleButtonProps({
44-
"aria-label": props.value,
44+
"aria-label": props.ariaLabel,
4545
ref: refs.setReference,
4646
onFocus: props.onFocus
4747
})}

0 commit comments

Comments
 (0)