Skip to content

Commit 8f3f960

Browse files
r0b1nr0b1n
committed
fix: update screenshot
1 parent 1de71e5 commit 8f3f960

File tree

4 files changed

+31
-31
lines changed

4 files changed

+31
-31
lines changed

‎packages/pluggableWidgets/datagrid-date-filter-web/e2e/DataGridDateFilter.spec.js-snapshots/dataGridDateFilter-chromium-linux.png

-131 Bytes
Loading

‎packages/pluggableWidgets/datagrid-dropdown-filter-web/e2e/DataGridDropDownFilter.spec.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -26,25 +26,25 @@ test.describe("datagrid-dropdown-filter-web", () => {
2626

2727
test.describe("using enumeration as attribute", () => {
2828
test("shows the expected result", async ({ page }) => {
29-
await page.click(".mx-name-datagrid1 .mx-name-dataGridDrop_downFilter1");
30-
await page.waitForSelector(".widget-dropdown-filter-menu-slot > ul > li:nth-child(2)");
31-
await page.click(".widget-dropdown-filter-menu-slot > ul > li:nth-child(2)");
29+
await page.locator(".mx-name-datagrid1 .mx-name-dataGridDrop_downFilter1").click({ delay: 1 });
30+
await page.waitForSelector(".widget-dropdown-filter-menu-slot > ul > li:nth-child(1)");
31+
await page.locator(".widget-dropdown-filter-menu-slot > ul > li:nth-child(1)").click({ delay: 1 });
3232
await page.waitForTimeout(300); // wait for filter to apply
33-
await page.click("#DataGrid4-column0");
33+
await page.locator("#DataGrid4-column0").click({ delay: 1 });
3434
const cells = await page.$$eval(".mx-name-datagrid1 .td", elements =>
3535
elements.map(element => element.textContent)
3636
);
3737
await expect(cells).toEqual(["10", "test", "test", "Yes", ""]);
3838
});
3939

4040
test("shows the expected result with multiple selected items", async ({ page }) => {
41-
await page.click(".mx-name-datagrid1 .mx-name-dataGridDrop_downFilter1");
41+
await page.locator(".mx-name-datagrid1 .mx-name-dataGridDrop_downFilter1").click({ delay: 1 });
4242
await page.waitForSelector(".widget-dropdown-filter-menu-slot > ul > li:nth-child(2)");
43-
await page.click(".widget-dropdown-filter-menu-slot > ul > li:nth-child(2)");
43+
await page.locator(".widget-dropdown-filter-menu-slot > ul > li:nth-child(1)").click({ delay: 1 });
4444
await page.waitForSelector(".widget-dropdown-filter-menu-slot > ul > li:nth-child(3)");
45-
await page.click(".widget-dropdown-filter-menu-slot > ul > li:nth-child(3)");
45+
await page.locator(".widget-dropdown-filter-menu-slot > ul > li:nth-child(2)").click({ delay: 1 });
4646
await page.waitForTimeout(300); // wait for filter to apply
47-
await page.click("#DataGrid4-column0");
47+
await page.locator("#DataGrid4-column0").click({ delay: 1 });
4848
const cells = await page.$$eval(".mx-name-datagrid1 .td", elements =>
4949
elements.map(element => element.textContent)
5050
);
@@ -54,20 +54,20 @@ test.describe("datagrid-dropdown-filter-web", () => {
5454

5555
test.describe("using boolean as attribute", () => {
5656
test("shows the expected result", async ({ page }) => {
57-
await page.getByRole("combobox", { name: "Empty" }).click();
57+
await page.getByRole("combobox", { name: "Active column filter" }).click({ delay: 1 });
5858
const dropdownItem = await page.locator(".widget-dropdown-filter-menu-slot > ul > li:nth-child(3)");
5959
await expect(dropdownItem).toHaveText("No");
60-
await dropdownItem.click();
61-
await page.locator("#DataGrid4-column1").click();
60+
await dropdownItem.click({ delay: 1 });
61+
await page.locator("#DataGrid4-column1").click({ delay: 1 });
6262
const cells = await page.locator(".mx-name-datagrid1 .tr");
6363
expect(cells).toHaveCount(1);
6464
});
6565

6666
test("shows no results when no items selected", async ({ page }) => {
67-
await page.getByRole("combobox", { name: "Empty" }).click();
67+
await page.getByRole("combobox", { name: "Active column filter" }).click({ delay: 1 });
6868
const dropdownItem = await page.locator(".widget-dropdown-filter-menu-slot > ul > li:nth-child(1)"); //the first item means none selected
69-
await dropdownItem.click();
70-
await page.locator("#DataGrid4-column1").click();
69+
await dropdownItem.click({ delay: 1 });
70+
await page.locator("#DataGrid4-column1").click({ delay: 1 });
7171
const cells = await page.locator(".mx-name-datagrid1 .tr");
7272
expect(cells).toHaveCount(4);
7373
});

‎packages/pluggableWidgets/datagrid-dropdown-filter-web/e2e/DataGridDropDownFilter.spec.js-snapshots/dataGridDropDownFilter-undefined-chromium-linux.png

-786 Bytes
Loading

‎packages/pluggableWidgets/datagrid-dropdown-filter-web/e2e/DataGridDropDownFilterAssociation.spec.js

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ test.describe("datagrid-dropdown-filter-web", () => {
1515
test("show list of Companies with empty option on top of the list", async ({ page }) => {
1616
const menu = () => page.locator("text=FMC Corp");
1717

18-
await page.locator(".mx-name-drop_downFilter2").click();
18+
await page.locator(".mx-name-drop_downFilter2").click({ delay: 1 });
1919
await expect(menu()).toBeVisible();
2020
const list = page.locator(".widget-dropdown-filter-menu-slot > ul > li");
2121
await expect(list).toHaveCount(21);
@@ -25,15 +25,15 @@ test.describe("datagrid-dropdown-filter-web", () => {
2525
});
2626

2727
test("set value after option is clicked", async ({ page }) => {
28-
const select = () => page.getByRole("columnheader", { name: "sort Company" }).getByLabel("Search");
28+
const select = () => page.getByRole("combobox", { name: "Company column filter" });
2929
const toggle = page.locator(".widget-dropdown-filter-toggle");
3030
const menu = () => page.locator("text=FMC Corp");
3131
const option1 = () => page.getByRole("option", { name: "Brown-Forman Corporation" });
32-
const clickOutside = async () => page.locator("body").click();
32+
const clickOutside = async () => page.locator("body").click({ delay: 1 });
3333

34-
await select().click();
34+
await select().click({ delay: 1 });
3535
await expect(menu()).toBeVisible();
36-
await option1().click();
36+
await option1().click({ delay: 1 });
3737
await expect(toggle.nth(3)).toHaveText("Brown-Forman Corporation");
3838
await clickOutside();
3939
await expect(menu()).not.toBeVisible();
@@ -45,25 +45,25 @@ test.describe("datagrid-dropdown-filter-web", () => {
4545

4646
test.describe("multiselect", () => {
4747
test("shows list of Roles", async ({ page }) => {
48-
const select = () => page.getByRole("columnheader", { name: "Roles" }).getByLabel("Search");
48+
const select = () => page.getByRole("combobox", { name: "Role column filter" });
4949
const menu = () => page.locator("text=Economist");
5050
const option1 = () => page.getByRole("option", { name: "Economist" });
5151
const option2 = () => page.getByRole("option", { name: "Public librarian" });
5252
const option3 = () => page.getByRole("option", { name: "Prison officer" });
5353

54-
await select().click();
54+
await select().click({ delay: 1 });
5555
await expect(menu().first()).toBeVisible();
5656
await expect(option1()).toBeVisible();
5757
await expect(option2()).toBeVisible();
5858
await expect(option3()).toBeVisible();
5959
});
6060

6161
test("does filtering when option is checked", async ({ page }) => {
62-
const select = () => page.getByRole("columnheader", { name: "Roles" }).getByLabel("Search");
62+
const select = () => page.getByRole("combobox", { name: "Role column filter" });
6363
const option2 = () => page.getByRole("option", { name: "Public librarian" });
6464

65-
await select().click();
66-
await option2().click();
65+
await select().click({ delay: 1 });
66+
await option2().click({ delay: 1 });
6767
const rows = page.locator(".mx-name-dataGrid21 .tr");
6868
await expect(rows).toHaveCount(5); // 4 rows + 1 header row
6969
});
@@ -73,9 +73,9 @@ test.describe("datagrid-dropdown-filter-web", () => {
7373
test("open menu with no options selected", async ({ page }) => {
7474
const select = () => page.locator(".mx-name-drop_downFilter1");
7575
const menu = () => page.getByRole("option", { name: "Environmental scientist" });
76-
const clickOutside = async () => (await page.locator("body")).click();
76+
const clickOutside = async () => (await page.locator("body")).click({ delay: 1 });
7777

78-
await select().click();
78+
await select().click({ delay: 1 });
7979
const checkedOptions = await menu().locator("input:checked");
8080
await expect(checkedOptions).toHaveCount(0);
8181
await clickOutside();
@@ -88,8 +88,8 @@ test.describe("datagrid-dropdown-filter-web", () => {
8888
const menu = () => page.getByRole("option", { name: "Environmental scientist" });
8989
const option1 = () => page.getByRole("option", { name: "Environmental scientist" });
9090

91-
await select().click();
92-
await option1().click();
91+
await select().click({ delay: 1 });
92+
await option1().click({ delay: 1 });
9393
const checkedOptions = await menu().locator("input:checked");
9494
await expect(checkedOptions).toHaveCount(1);
9595
await expect(checkedOptions.first()).toBeChecked();
@@ -106,9 +106,9 @@ test.describe("datagrid-dropdown-filter-web", () => {
106106
const option1 = () => page.getByRole("option", { name: "Environmental scientist" });
107107
const option2 = () => page.getByRole("option", { name: "Trader" });
108108

109-
await select().click();
110-
await option1().click();
111-
await option2().click();
109+
await select().click({ delay: 1 });
110+
await option1().click({ delay: 1 });
111+
await option2().click({ delay: 1 });
112112
const checkedOptions = await menu().locator("input:checked");
113113
await expect(checkedOptions).toHaveCount(2);
114114
await expect(checkedOptions.first()).toBeChecked();

0 commit comments

Comments
 (0)