Skip to content

Commit c9cfb25

Browse files
committed
chore: fix dropdown titles
1 parent 7ded2df commit c9cfb25

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

packages/pluggableWidgets/datagrid-dropdown-filter-web/e2e/DataGridDropDownFilter.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ test.describe("datagrid-dropdown-filter-web", () => {
5454

5555
test.describe("using boolean as attribute", () => {
5656
test("shows the expected result", async ({ page }) => {
57-
await page.getByRole("combobox", { name: "Select me" }).click({ delay: 1 });
57+
await page.getByRole("combobox", { name: "Active column filter" }).click({ delay: 1 });
5858
const dropdownItem = await page.locator(".widget-dropdown-filter-menu-slot > ul > li:nth-child(3)");
5959
await expect(dropdownItem).toHaveText("No");
6060
await dropdownItem.click({ delay: 1 });
@@ -64,7 +64,7 @@ test.describe("datagrid-dropdown-filter-web", () => {
6464
});
6565

6666
test("shows no results when no items selected", async ({ page }) => {
67-
await page.getByRole("combobox", { name: "Select me" }).click({ delay: 1 });
67+
await page.getByRole("combobox", { name: "Active column filter" }).click({ delay: 1 });
6868
const dropdownItem = await page.locator(".widget-dropdown-filter-menu-slot > ul > li:nth-child(1)"); //the first item means none selected
6969
await dropdownItem.click({ delay: 1 });
7070
await page.locator("#DataGrid4-column1").click({ delay: 1 });

packages/pluggableWidgets/datagrid-dropdown-filter-web/e2e/DataGridDropDownFilterAssociation.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ test.describe("datagrid-dropdown-filter-web", () => {
2525
});
2626

2727
test("set value after option is clicked", async ({ page }) => {
28-
const select = () => page.getByRole("combobox", { name: "Select company" });
28+
const select = () => page.getByRole("combobox", { name: "Company column filter" });
2929
const toggle = page.locator(".widget-dropdown-filter-toggle");
3030
const menu = () => page.locator("text=FMC Corp");
3131
const option1 = () => page.getByRole("option", { name: "Brown-Forman Corporation" });
@@ -47,7 +47,7 @@ test.describe("datagrid-dropdown-filter-web", () => {
4747
let select;
4848
let menu;
4949
test.beforeEach(async ({ page }) => {
50-
select = () => page.getByRole("combobox", { name: "Select role" });
50+
select = () => page.getByRole("combobox", { name: "Role column filter" });
5151
menu = () => select().getByRole("listbox");
5252
});
5353
test("shows list of Roles", async ({ page }) => {

0 commit comments

Comments
 (0)