Skip to content

Conversation

@iobuhov
Copy link
Collaborator

@iobuhov iobuhov commented Nov 11, 2025

Pull request type

Dependency changes (any modification to dependencies in package.json)

New feature (non-breaking change which adds functionality)


Description

Add mobx utils.

@iobuhov iobuhov requested a review from a team as a code owner November 11, 2025 07:42
Copilot AI review requested due to automatic review settings November 11, 2025 07:42
Copilot finished reviewing on behalf of iobuhov November 11, 2025 07:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new MobX utility functions to the @mendix/widget-plugin-mobx-kit package. The changes reorganize the codebase by moving existing utilities to a lib/ directory and introduce new utilities for event emission, atom factories, and computed atoms.

Key changes:

  • Adds three new utility functions: createEmitter, atomFactory, and autoEffect (relocated)
  • Reorganizes codebase structure by moving utilities to src/lib/ directory
  • Removes deprecated useSubscribe React hook and its tests
  • Adds mitt library as a dependency for event emission functionality

Reviewed Changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pnpm-lock.yaml Adds [email protected] dependency to lockfile
package.json Adds mitt dependency to widget-plugin-mobx-kit package
src/main.ts Updates exports to include new utilities and reflect reorganized structure
src/lib/disposeBatch.ts Moves disposeBatch function to lib directory
src/lib/createEmitter.ts Adds new event emitter utility wrapping mitt
src/lib/autoEffect.ts Moves autoEffect function to lib directory
src/lib/atomFactory.ts Adds new factory function for creating computed atoms
src/interfaces/ComputedAtom.ts Adds interface for computed atom type
src/disposeBatch.ts Adds deprecation wrapper for backward compatibility
src/SetupHost.ts Updates import path for disposeBatch
test/useSubscribe.test.ts Removes tests for deleted useSubscribe hook
test/createEmitter.test.ts Adds comprehensive tests for new createEmitter utility
test/atomFactory.test.ts Adds comprehensive tests for new atomFactory utility
test/autoEffect.test.ts Updates import path to reflect reorganization
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

packages/shared/widget-plugin-mobx-kit/package.json:3

  • New feature added but no version bump in package.json. Please bump semver (e.g., to 0.2.0) and add a CHANGELOG.md entry. You can use pnpm -w changelog to help with this.
    "version": "0.1.0",

@iobuhov iobuhov merged commit d216baf into main Nov 13, 2025
14 checks passed
@iobuhov iobuhov deleted the mobx-tools branch November 13, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants