Skip to content

Commit 949db7a

Browse files
pass check-report errors to next job using artifact
1 parent 28eccde commit 949db7a

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

.github/workflows/build.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,14 @@ jobs:
373373
--api-url=${{ github.event.pull_request._links.self.href }}
374374
cd ..
375375
376+
- name: Upload chart_report errors
377+
uses: actions/upload-artifact@v4
378+
if: ${{ always() && steps.check_report.outcome == 'failure' }}
379+
with:
380+
name: chart_report_errors
381+
path: pr/errors
382+
if-no-files-found: ignore
383+
376384
- name: Delete Namespace
377385
if: ${{ always() && steps.oc_login.conclusion == 'success' }}
378386
env:
@@ -428,11 +436,20 @@ jobs:
428436
../ve1/bin/pip3 install .
429437
cd ..
430438
439+
# Submission information should always be present
431440
- name: Download submission information
432441
uses: actions/download-artifact@v4
433442
with:
434443
name: submission
435444

445+
# Chart report errors are only present if any error has occured during the chart_report
446+
- name: Download chart_report errors
447+
uses: actions/download-artifact@v4
448+
if: ${{ needs.chart-verifier.outputs.check_report-outcome || 'skipped' == 'failure' }}
449+
with:
450+
name: chart_report_errors
451+
path: pr/
452+
436453
- name: Prepare PR comment
437454
id: pr_comment
438455
if: ${{ needs.setup.outputs.run_build == 'true' }}

scripts/src/pullrequest/prepare_pr_comment.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def prepare_failure_comment():
6161
msg = append_to(msg, get_verifier_errors_comment())
6262
msg = append_to(msg, errors)
6363
msg = append_to(msg, get_verifier_errors_trailer())
64-
gitutils.add_output("error-message", errors)
64+
# gitutils.add_output("error-message", errors)
6565
else:
6666
gitutils.add_output("error-message", get_failure_comment())
6767
return msg

0 commit comments

Comments
 (0)