Skip to content

Commit 1183b1a

Browse files
authored
fix: Use ghTokenWorkflow for CheckForUpdates in CreateRelease.yaml (#1503)
Fixes #1475 (hopefully completely this time) My apologies Freddy, but I think I messed up when I tested #1477... CI/CD worked just as intended, but "Create Release" did not work. It ended up with a 404 error. It seemed as if the token sent to the CreateRelase action was empty: ``` _actor: jwikman _token: <---------- _templateUrl: https://github.com/[redacted]/AL-Go-PTE@preview _downloadLatest: true _update: N _updateBranch: main _directCommit: false ``` After the proposed change, the token is passed as expected ``` _actor: jwikman _token: *** <--------------------- _templateUrl: https://github.com/[redacted]/AL-Go-PTE@preview _downloadLatest: true _update: N _updateBranch: main _directCommit: false ``` I do not fully follow the logic with the `TokenForPush` secret, but that token did not seem to work in this context?
1 parent 4dd210d commit 1183b1a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Templates/AppSource App/.github/workflows/CreateRelease.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ jobs:
104104
with:
105105
shell: powershell
106106
gitHubSecrets: ${{ toJson(secrets) }}
107-
getSecrets: 'TokenForPush'
107+
getSecrets: 'TokenForPush,ghTokenWorkflow'
108108
useGhTokenWorkflowForPush: '${{ github.event.inputs.useGhTokenWorkflow }}'
109109

110110
- name: Determine Projects
@@ -118,7 +118,7 @@ jobs:
118118
with:
119119
shell: powershell
120120
templateUrl: ${{ env.templateUrl }}
121-
token: ${{ fromJson(steps.ReadSecrets.outputs.Secrets).TokenForPush }}
121+
token: ${{ fromJson(steps.ReadSecrets.outputs.Secrets).ghTokenWorkflow }}
122122
downloadLatest: true
123123

124124
- name: Analyze Artifacts

Templates/Per Tenant Extension/.github/workflows/CreateRelease.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ jobs:
104104
with:
105105
shell: powershell
106106
gitHubSecrets: ${{ toJson(secrets) }}
107-
getSecrets: 'TokenForPush'
107+
getSecrets: 'TokenForPush,ghTokenWorkflow'
108108
useGhTokenWorkflowForPush: '${{ github.event.inputs.useGhTokenWorkflow }}'
109109

110110
- name: Determine Projects
@@ -118,7 +118,7 @@ jobs:
118118
with:
119119
shell: powershell
120120
templateUrl: ${{ env.templateUrl }}
121-
token: ${{ fromJson(steps.ReadSecrets.outputs.Secrets).TokenForPush }}
121+
token: ${{ fromJson(steps.ReadSecrets.outputs.Secrets).ghTokenWorkflow }}
122122
downloadLatest: true
123123

124124
- name: Analyze Artifacts

0 commit comments

Comments
 (0)