Skip to content

Commit 2beb736

Browse files
authored
Move power platform scenario to App Auth (#1699)
* Move power platform scenario to App Auth * Use the GitHub owner output by GetOwnerForE2ETests during cleanup. Fixes this issue: https://github.com/microsoft/AL-Go/actions/runs/14750830165 The following PRs need to be merged before this one can go in: * microsoft/bcsamples-warehousehelper#5 * microsoft/bcsamples-takeorder#13 * microsoft/bcsamples-CoffeeMR#7 Related to [AB#573954](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/573954)
1 parent cea4a38 commit 2beb736

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

.github/workflows/CleanupTempRepos.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,6 @@ jobs:
3030
with:
3131
egress-policy: audit
3232

33-
- uses: actions/create-github-app-token@df432ceedc7162793a195dd1713ff69aefc7379e # v2.0.6
34-
id: app-token
35-
if: ${{ vars.E2E_APP_ID != '' }}
36-
with:
37-
app-id: ${{ vars.E2E_APP_ID }}
38-
private-key: ${{ secrets.E2E_PRIVATE_KEY }}
39-
owner: ${{ github.event.inputs.githubOwner }}
40-
4133
- name: Check E2EPAT Secret is defined
4234
if: ${{ vars.E2E_APP_ID == '' }}
4335
run: |
@@ -55,6 +47,14 @@ jobs:
5547
run: |
5648
${{ github.workspace }}/Internal/Scripts/GetOwnerForE2ETests.ps1 -githubOwner $env:githubOwner
5749
50+
- uses: actions/create-github-app-token@3ff1caaa28b64c9cc276ce0a02e2ff584f3900c5 # v2.0.2
51+
id: app-token
52+
if: ${{ vars.E2E_APP_ID != '' }}
53+
with:
54+
app-id: ${{ vars.E2E_APP_ID }}
55+
private-key: ${{ secrets.E2E_PRIVATE_KEY }}
56+
owner: ${{ steps.getGitHubOwner.outputs.githubOwner }}
57+
5858
- name: Cleanup Temp Repositories
5959
env:
6060
githubOwner: ${{ steps.getGitHubOwner.outputs.githubOwner }}

e2eTests/scenarios/PowerPlatform/runtest.ps1

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,8 @@ foreach($sourceRepo in $repositories) {
7373
Write-Host "PowerPlatform Solution Folder: $($settings.powerPlatformSolutionFolder)"
7474

7575
# Upgrade AL-Go System Files to test version
76-
# TODO: Use e2epat until bcsamples powerplatform repositories have been updated to latest version
77-
RunUpdateAlGoSystemFiles -directCommit -wait -templateUrl $template -ghTokenWorkflow $e2epat -repository $repository | Out-Null
78-
7976
SetRepositorySecret -repository $repository -name 'GHTOKENWORKFLOW' -value $algoauthapp
77+
RunUpdateAlGoSystemFiles -directCommit -templateUrl $template -wait -repository $repository | Out-Null
8078

8179
CancelAllWorkflows -repository $repository
8280

0 commit comments

Comments
 (0)