3 bugs in v6.4 (#1523)

Do not remove downloaded apps from PR builds, they might be needed by
other projects being built.
Fixes #1521

and

Remove unnecessary warnings from deployment
Fixes #1522

and

if settings.workflowSchedule doesn't exist - Update AL-Go System files
fails when running on a schedule
Fixes #1524

---------

Co-authored-by: freddydk <[email protected]>

Author: freddydk

Actions/Deploy/Deploy.ps1

@@ -20,10 +20,10 @@ function CheckIfAppNeedsInstallOrUpgrade {
     $needsInstall = $false
     $needsUpgrade = $false
     if ($installedApp) {
-        $newVersion = [version]::new($appJson.Version)
+        $dependencyVersion = [version]::new($appJson.Version)
         $installedVersion = [version]::new($installedApp.versionMajor, $installedApp.versionMinor, $installedApp.versionBuild, $installedApp.versionRevision)
-        if ($newVersion -gt $installedVersion) {
-            $msg = "Dependency app $($appJson.name) is already installed in version $installedVersion, which is lower than $newVersion."
+        if ($dependencyVersion -gt $installedVersion) {
+            $msg = "Dependency app $($appJson.name) is already installed in version $installedVersion, which is lower than $dependencyVersion."
             if ($installMode -eq 'upgrade') {
                 Write-Host "$msg Needs upgrade."
                 $needsUpgrade = $true
@@ -32,8 +32,8 @@ function CheckIfAppNeedsInstallOrUpgrade {
                 Write-Host "::WARNING::$msg Set DependencyInstallMode to 'upgrade' or 'forceUpgrade' to upgrade dependencies."
             }
         }
-        elseif ($newVersion -lt $installedVersion) {
-            Write-Host "::WARNING::Dependency app $($appJson.name) is already installed in version $installedVersion, which is higher than $newVersion, used for this build. Please update your local copy of this dependency."
+        elseif ($dependencyVersion -lt $installedVersion) {
+            Write-Host "Dependency app $($appJson.name) is already installed in version $installedVersion, which is higher than $dependencyVersion, used in app.json."
         }
         else {
             Write-Host "Dependency app $($appJson.name) is already installed in version $installedVersion."
@@ -216,7 +216,7 @@ if (Test-Path $artifactsFolder -PathType Container) {
         else {
             $allApps += $projectApps
         }
-        if (!($projectTestApps)) {
+        if ($deploymentSettings.includeTestAppsInSandboxEnvironment -and !($projectTestApps)) {
             if ($project -ne '*') {
                 Write-Host "::warning::There are no artifacts present in $artifactsFolder matching $project-$refname-$($buildMode)TestApps-<version>."
             }
@@ -259,7 +259,7 @@ else {
 
 # Calculate unknown dependencies for all apps and known dependencies
 $unknownDependencies = @()
-Sort-AppFilesByDependencies -appFiles @($apps + $dependencies) -unknownDependencies ([ref]$unknownDependencies) | Out-Null
+Sort-AppFilesByDependencies -appFiles @($apps + $dependencies) -unknownDependencies ([ref]$unknownDependencies) -WarningAction SilentlyContinue | Out-Null
 
 Write-Host "Apps to deploy"
 $apps | ForEach-Object {

Actions/GetWorkflowMultiRunBranches/GetWorkflowMultiRunBranches.ps1

@@ -12,11 +12,12 @@ switch ($env:GITHUB_EVENT_NAME) {
       $settings = ConvertFrom-Json $env:settings
 
       # Add defensive check to handle if workflowSchedule.includeBranches is not defined in settings
-      if (-not $($settings.workflowSchedule.includeBranches)) {
+      if (($settings.PSObject.Properties.Name -eq "workflowSchedule") -and ($settings.workflowSchedule.PSObject.Properties.Name -eq "includeBranches") -and $($settings.workflowSchedule.includeBranches)) {
+        $branchPatterns = @($($settings.workflowSchedule.includeBranches))
+      }
+      else {
         Write-Host "No branch patterns defined in settings"
         $branchPatterns = @()
-      } else {
-        $branchPatterns = @($($settings.workflowSchedule.includeBranches))
       }
     }
     'workflow_dispatch' {

Actions/RunPipeline/RunPipeline.ps1

@@ -509,28 +509,6 @@ try {
         -appBuild $appBuild -appRevision $appRevision `
         -uninstallRemovedApps
 
-    # If any apps were downloaded as part of incremental builds in a pr, we should remove them again after the build to prevent them from being included in artifacts
-    if ($ENV:GITHUB_EVENT_NAME -like 'pull_request*' -and $downloadedAppsByType) {
-        $downloadedAppsByType | ForEach-Object {
-            if ($_.downloadedApps) {
-                $mask = $_.mask
-                $thisArtifactFolder = Join-Path $buildArtifactFolder $mask
-                Write-Host "Removing pre-built apps from $thisArtifactFolder"
-                foreach($downloadedApp in $_.downloadedApps) {
-                    $thisApp = Join-Path $thisArtifactFolder $downloadedApp
-                    try {
-                        if (Test-Path $thisApp) {
-                            Remove-Item $thisApp
-                        }
-                        Write-Host "Removed pre-built app: $thisApp"
-                    } catch {
-                        Write-Host "Failed to remove pre-built app: $thisApp"
-                    }
-                }
-            }
-        }
-    }
-
     if ($containerBaseFolder) {
         Write-Host "Copy artifacts and build output back from build container"
         $destFolder = Join-Path $ENV:GITHUB_WORKSPACE $project