Skip to content

Commit 9600f31

Browse files
authored
Obsoleting Session Store (#4187)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> The usage of Session Store Codeunit for Subscription Billing has been obsoleted. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #4172 Fixes [AB#597483](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/597483)
1 parent 8755822 commit 9600f31

File tree

3 files changed

+8
-44
lines changed

3 files changed

+8
-44
lines changed

src/Apps/W1/Subscription Billing/App/Base/Codeunits/SessionStore.Codeunit.al

Lines changed: 0 additions & 30 deletions
This file was deleted.

src/Apps/W1/Subscription Billing/App/Permission Sets/SubBillingObjects.PermissionSet.al

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ permissionset 8001 "Sub. Billing Objects"
4242
codeunit "Sales Documents" = X,
4343
codeunit "Sales Report Printout Mgmt." = X,
4444
codeunit "Sales Subscription Line Mgmt." = X,
45-
codeunit "Session Store" = X,
4645
codeunit "Sub. Billing Activities Cue" = X,
4746
codeunit "Sub. Billing Installation" = X,
4847
codeunit "Sub. Contr. Renewal Subcribers" = X,

src/Apps/W1/Subscription Billing/App/Sales Service Commitments/Codeunits/SalesSubscriptionLineMgmt.Codeunit.al

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ codeunit 8069 "Sales Subscription Line Mgmt."
1515
[EventSubscriber(ObjectType::Table, Database::"Sales Line", OnAfterInsertEvent, '', false, false)]
1616
local procedure SalesLineOnAfterInsertEvent(var Rec: Record "Sales Line"; RunTrigger: Boolean)
1717
begin
18-
if IsSalesLineRestoreInProgress(Rec) then
18+
if SalesLineRestoreInProgress then
1919
exit;
2020
if RunTrigger then
2121
AddSalesServiceCommitmentsForSalesLine(Rec, false);
@@ -344,21 +344,16 @@ codeunit 8069 "Sales Subscription Line Mgmt."
344344
TransferServiceCommitments(BlanketOrderSalesLine, SalesOrderLine);
345345
end;
346346

347-
[EventSubscriber(ObjectType::Codeunit, Codeunit::ArchiveManagement, OnRestoreSalesLinesOnBeforeSalesLineInsert, '', false, false)]
348-
local procedure SetSalesLineRestoreInProgressOnRestoreSalesLinesOnBeforeSalesLineInsert(var SalesLine: Record "Sales Line")
347+
[EventSubscriber(ObjectType::Codeunit, Codeunit::ArchiveManagement, OnRestoreDocumentOnBeforeDeleteSalesHeader, '', false, false)]
348+
local procedure SetSalesLineRestoreInProgressOnRestoreDocumentOnBeforeDeleteSalesHeader()
349349
begin
350-
SessionStore.SetBooleanKey('SalesLineRestoreInProgress ' + Format(SalesLine.RecordId()), true);
350+
SalesLineRestoreInProgress := true;
351351
end;
352352

353-
[EventSubscriber(ObjectType::Codeunit, Codeunit::ArchiveManagement, OnRestoreSalesLinesOnAfterSalesLineInsert, '', false, false)]
354-
local procedure RemoveSalesLineRestoreInProgressOnRestoreSalesLinesOnAfterSalesLineInsert(var SalesLine: Record "Sales Line")
353+
[EventSubscriber(ObjectType::Codeunit, Codeunit::ArchiveManagement, OnAfterRestoreSalesDocument, '', false, false)]
354+
local procedure RemoveSalesLineRestoreInProgressOnAfterRestoreSalesDocument()
355355
begin
356-
SessionStore.RemoveBooleanKey('SalesLineRestoreInProgress ' + Format(SalesLine.RecordId()));
357-
end;
358-
359-
local procedure IsSalesLineRestoreInProgress(var SalesLine: Record "Sales Line"): Boolean
360-
begin
361-
exit(SessionStore.GetBooleanKey('SalesLineRestoreInProgress ' + Format(SalesLine.RecordId())));
356+
SalesLineRestoreInProgress := false;
362357
end;
363358

364359
internal procedure GetItemNoForSalesServiceCommitment(var SalesLine: Record "Sales Line"; ServiceCommitmentPackageLine: Record "Subscription Package Line"): Code[20]
@@ -521,8 +516,8 @@ codeunit 8069 "Sales Subscription Line Mgmt."
521516
end;
522517

523518
var
524-
SessionStore: Codeunit "Session Store";
525519
ItemManagement: Codeunit "Sub. Contracts Item Management";
526520
ServiceCommitmentWithNegativeQtyMessageThrown: Boolean;
521+
SalesLineRestoreInProgress: Boolean;
527522
ServiceObjectNotCreatedMsg: Label 'For negative quantity the Subscription is not created.';
528523
}

0 commit comments

Comments
 (0)