Description
Describe the issue
Values in fields "Billing Base Period" and "Billing Rhythm" should always have a valid combination which means that ratio between those two fields should always be a natural (integer) number.
Examples of valid combinations:
12M/12M
1Y/12M
1M/12M
3Y/1Y
1Q/1Y
Examples of invalid combinations:
12M/15M
1W/1M
1Q/15M
Expected behavior
The check if the value combination is valid currently happens in OnModify trigger. This is suboptimal as it does not run in Insert scenario.
Steps to reproduce
- Create new Subscription Package
- Create new Package Line
- Enter 12M in "Billing Base Period" field
- Enter 15M in "Billing Rhythm" field - at this point of time the error is expected as 12M/15M is not allowed combination since only natural ratios are allowed
- Create second Package Line
- Enter 12M in "Billing Base Period" field
- Enter 12M in "Billing Rhythm" field
- Close the Subscription Package page
- Open the same Subscription Package again
- Try to change the value for "Billing Rhythm" to 15M for second line - the error appears: The ratio of 'Billing Base Period' and 'Billing Rhythm' or vice versa must give a natural number.
Additional context
There is already an approved issue on ALAppExtensions Repo:
microsoft/ALAppExtensions#28761
I will provide a fix for a bug
- I will provide a fix for a bug