Tidy for basic, nobuiltins, add a basic headers check (#7117)

Author: achamayou

.clang-tidy

@@ -45,7 +45,9 @@ Checks: >
   -cppcoreguidelines-pro-type-vararg,
   -misc-no-recursion,
   -cert-dcl50-cpp,
-  -performance-no-int-to-ptr
+  -performance-no-int-to-ptr,
+  -clang-analyzer-optin.cplusplus.VirtualCall,
+  -cppcoreguidelines-rvalue-reference-param-not-moved
 
 WarningsAsErrors: '*'
 HeaderFilterRegex: '?!(3rdparty)'

CHANGELOG.md

@@ -14,6 +14,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - CCF no longer has platform-specific builds. The single build configuration will run on both SNP and Virtual, automatically detecting the current platform at runtime. This means the `COMPILE_TARGET` CMake option is no longer required, and all release artifacts no longer have a platform in their path.
 - The `logging.host_level` configuration option and `--enclave-log-level` CLI switch are replaced by a combined `--log-level` CLI switch (#7104).
 
+### Removed
+
+- The `ccf/pal/hardware_info.h` header has been removed (#7117).
+
 ## [7.0.0-dev0]
 
 [7.0.0-dev0]: https://github.com/microsoft/CCF/releases/tag/ccf-7.0.0-dev0

CMakeLists.txt

@@ -249,9 +249,9 @@ list(APPEND CCHOST_SOURCES ${CCF_DIR}/src/host/main.cpp
 
 add_executable(cchost ${CCHOST_SOURCES})
 
-add_warning_checks(cchost)
 add_san(cchost)
 add_tidy(cchost)
+add_warning_checks(cchost)
 
 target_compile_options(
   cchost PRIVATE ${COMPILE_LIBCXX} ${SNMALLOC_COMPILE_OPTIONS}
@@ -310,11 +310,13 @@ set(CCF_JS_SOURCES
 )
 
 add_host_library(ccf_js "${CCF_JS_SOURCES}")
+
 add_san(ccf_js)
 add_tidy(ccf_js)
+add_warning_checks(ccf_js)
+
 target_link_libraries(ccf_js PUBLIC ccfcrypto quickjs)
 target_compile_definitions(ccf_js PRIVATE CCF_LOGGER_NO_DEPRECATE)
-add_warning_checks(ccf_js)
 if(CCF_DEVEL)
   install(
     TARGETS ccf_js
@@ -330,9 +332,11 @@ set(CCF_KV_SOURCES
 )
 
 add_host_library(ccf_kv "${CCF_KV_SOURCES}")
+
 add_san(ccf_kv)
-add_warning_checks(ccf_kv)
 add_tidy(ccf_kv)
+add_warning_checks(ccf_kv)
+
 target_compile_definitions(ccf_kv PRIVATE CCF_LOGGER_NO_DEPRECATE)
 if(CCF_DEVEL)
   install(
@@ -345,12 +349,14 @@ endif()
 # CCF endpoints lib
 add_host_library(ccf_endpoints "${CCF_ENDPOINTS_SOURCES}")
 target_include_directories(ccf_endpoints PRIVATE ${CCF_DIR}/src/endpoints)
-add_tidy(ccf_endpoints)
 target_link_libraries(
   ccf_endpoints PUBLIC qcbor t_cose http_parser ccfcrypto ccf_kv
 )
+
 add_san(ccf_endpoints)
+add_tidy(ccf_endpoints)
 add_warning_checks(ccf_endpoints)
+
 target_compile_definitions(ccf_endpoints PRIVATE CCF_LOGGER_NO_DEPRECATE)
 if(CCF_DEVEL)
   install(
@@ -464,7 +470,6 @@ add_library(ccf STATIC ${CCF_IMPL_SOURCE})
 target_compile_definitions(ccf PUBLIC INSIDE_ENCLAVE VIRTUAL_ENCLAVE)
 
 target_compile_options(ccf PUBLIC ${COMPILE_LIBCXX})
-add_warning_checks(ccf)
 target_compile_definitions(ccf PRIVATE CCF_LOGGER_NO_DEPRECATE)
 
 target_include_directories(
@@ -490,8 +495,10 @@ target_link_libraries(
 )
 
 set_property(TARGET ccf PROPERTY POSITION_INDEPENDENT_CODE ON)
+
 add_san(ccf)
 add_tidy(ccf)
+add_warning_checks(ccf)
 
 if(CCF_DEVEL)
   install(

cmake/ccf_app.cmake

@@ -44,6 +44,7 @@ function(add_ccf_app name)
   set_property(TARGET ${name} PROPERTY POSITION_INDEPENDENT_CODE ON)
 
   add_san(${name})
+  add_tidy(${name})
 
   add_dependencies(${name} ${name})
   if(PARSED_ARGS_DEPS)

include/ccf/ds/json.h

@@ -412,7 +412,7 @@ namespace std
     } \
     catch (ccf::JsonParseError & jpe) \
     { \
-      jpe.pointer_elements.push_back(JSON_FIELD); \
+      jpe.pointer_elements.emplace_back(JSON_FIELD); \
       throw; \
     } \
   }

include/ccf/pal/hardware_info.h

@@ -13,5 +13,5 @@ namespace ccf
    * @return an optional claims digest
    */
   std::optional<ccf::ClaimsDigest::Digest> get_create_tx_claims_digest(
-    ccf::kv::ReadOnlyTx& tx)
+    ccf::kv::ReadOnlyTx& tx);
 }

include/ccf/research/create_tx_claims_digest.h

@@ -45,7 +45,7 @@ namespace basicapp
           return;
         }
 
-        auto records_handle = ctx.tx.template rw<RecordsMap>(PRIVATE_RECORDS);
+        auto* records_handle = ctx.tx.template rw<RecordsMap>(PRIVATE_RECORDS);
         records_handle->put(key, ctx.rpc_ctx->get_request_body());
         ctx.rpc_ctx->set_response_status(HTTP_STATUS_NO_CONTENT);
       };
@@ -67,7 +67,7 @@ namespace basicapp
           return;
         }
 
-        auto records_handle = ctx.tx.template ro<RecordsMap>(PRIVATE_RECORDS);
+        auto* records_handle = ctx.tx.template ro<RecordsMap>(PRIVATE_RECORDS);
         auto record = records_handle->get(key);
 
         if (record.has_value())
@@ -96,7 +96,7 @@ namespace basicapp
 
         const auto records = body.get<std::map<std::string, std::string>>();
 
-        auto records_handle = ctx.tx.template rw<RecordsMap>(PRIVATE_RECORDS);
+        auto* records_handle = ctx.tx.template rw<RecordsMap>(PRIVATE_RECORDS);
         for (const auto& [key, value] : records)
         {
           const std::vector<uint8_t> value_vec(value.begin(), value.end());