From 03688437846b62e332abb534908b8b4ecd8e4174 Mon Sep 17 00:00:00 2001 From: Tex Riddell Date: Wed, 28 May 2025 15:51:41 -0700 Subject: [PATCH] Report error on dxc --version instead of error on None group --- tools/clang/test/lit.cfg | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/clang/test/lit.cfg b/tools/clang/test/lit.cfg index a3a352071c..f7cc57c46b 100644 --- a/tools/clang/test/lit.cfg +++ b/tools/clang/test/lit.cfg @@ -510,9 +510,13 @@ if config.metal: # Check supported dxil version def get_dxil_version(): result = subprocess.run([lit.util.which('dxc', llvm_tools_dir), "--version"], stdout=subprocess.PIPE) + if result.returncode != 0: + raise RuntimeError("dxc --version failed with return code %d" % result.returncode) output = result.stdout.decode("utf-8") dxcPat = re.compile(r"(dxcompiler.dll|libdxcompiler.so|libdxcompiler.dylib): (?P[0-9]+)\.(?P[0-9]+).") m = dxcPat.search(output) + if not m: + raise RuntimeError("Could not find dxc version in output:\n" + output) dxcMajor = int(m.group("dxcMajor")) dxcMinor = int(m.group("dxcMinor"))