Rename and better document allowsTreeSupersetOf #25897
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
jumyhre
requested changes
Nov 20, 2025
Contributor
jumyhre
left a comment
jumyhre
left a comment
There was a problem hiding this comment.
couple minor typos in the comment block for allowedMonotonicUpgrade, but looks good otherwise
jumyhre
reviewed
Nov 21, 2025
| * True if a client should be able to {@link TreeView.upgradeSchema} from a field schema using this field kind and `originalTypes` to `superset`. | ||
| * @remarks | ||
| * Used by {@link FlexFieldKind.allowsFieldSuperset}, which handles the `never` cases before calling this. | ||
| * Must return false if such an upgrade could violate and invariants of `superset` any document which is compatible with this + `originalTypes`. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Must return false if such an upgrade could violate and invariants of `superset` any document which is compatible with this + `originalTypes`. | |
| * Must return false if such an upgrade could violate any invariants of `superset` any document which is compatible with this + `originalTypes`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename and better document allowsTreeSupersetOf
Reviewer Guidance
The review process is outlined on this wiki page.