call nodes too, this is sus

Author: jakebailey

src/compiler/checker.ts

@@ -37952,6 +37952,14 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
             if (importCallOptionsType !== emptyObjectType) {
                 checkTypeAssignableTo(optionsType, getNullableType(importCallOptionsType, TypeFlags.Undefined), node.arguments[1]);
             }
+            if (compilerOptions.ignoreDeprecations !== "6.0" && isObjectLiteralExpression(node.arguments[1])) {
+                for (const prop of node.arguments[1].properties) {
+                    if (isPropertyAssignment(prop) && isIdentifier(prop.name) && prop.name.escapedText === "assert") {
+                        grammarErrorOnNode(prop.name, Diagnostics.Import_assertions_have_been_replaced_by_import_attributes_Use_with_instead_of_assert);
+                        break;
+                    }
+                }
+            }
         }
 
         // resolveExternalModuleName will return undefined if the moduleReferenceExpression is not a string literal

tests/baselines/reference/importTypeAssertionDeprecation.errors.txt

@@ -1,15 +1,24 @@
 /main.ts(1,38): error TS2880: Import assertions have been replaced by import attributes. Use 'with' instead of 'assert'.
 /main.ts(2,38): error TS2880: Import assertions have been replaced by import attributes. Use 'with' instead of 'assert'.
+/main.ts(4,31): error TS2880: Import assertions have been replaced by import attributes. Use 'with' instead of 'assert'.
+/main.ts(5,31): error TS2880: Import assertions have been replaced by import attributes. Use 'with' instead of 'assert'.
 
 
 ==== /types.d.ts (0 errors) ====
     export interface MyType { x: string }
 
-==== /main.ts (2 errors) ====
+==== /main.ts (4 errors) ====
     type A = import("./types", { assert: { "resolution-mode": "import" } }).MyType;
                                          ~
 !!! error TS2880: Import assertions have been replaced by import attributes. Use 'with' instead of 'assert'.
     type B = import("./types", { assert: { "resolution-mode": "require" } }).MyType;
                                          ~
 !!! error TS2880: Import assertions have been replaced by import attributes. Use 'with' instead of 'assert'.
+    
+    const a = import("./types", { assert: { "resolution-mode": "import" } });
+                                  ~~~~~~
+!!! error TS2880: Import assertions have been replaced by import attributes. Use 'with' instead of 'assert'.
+    const b = import("./types", { assert: { "resolution-mode": "require" } });
+                                  ~~~~~~
+!!! error TS2880: Import assertions have been replaced by import attributes. Use 'with' instead of 'assert'.
 

tests/cases/compiler/importTypeAssertionDeprecation.ts

@@ -9,3 +9,6 @@ export interface MyType { x: string }
 // @Filename: /main.ts
 type A = import("./types", { assert: { "resolution-mode": "import" } }).MyType;
 type B = import("./types", { assert: { "resolution-mode": "require" } }).MyType;
+
+const a = import("./types", { assert: { "resolution-mode": "import" } });
+const b = import("./types", { assert: { "resolution-mode": "require" } });

tests/cases/compiler/importTypeAssertionDeprecationIgnored.ts

@@ -11,3 +11,6 @@ export interface MyType { x: string }
 // With ignoreDeprecations: "6.0", import type assertions should not produce a deprecation error.
 type A = import("./types", { assert: { "resolution-mode": "import" } }).MyType;
 type B = import("./types", { assert: { "resolution-mode": "require" } }).MyType;
+
+const a = import("./types", { assert: { "resolution-mode": "import" } });
+const b = import("./types", { assert: { "resolution-mode": "require" } });