Set default types array to []; support "*" wildcard (#63054)

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>

Author: RyanCavanaugh

src/compiler/checker.ts

@@ -911,6 +911,7 @@ import {
     NodeBuilderFlags,
     nodeCanBeDecorated,
     NodeCheckFlags,
+    nodeCoreModules,
     NodeFlags,
     nodeHasName,
     nodeIsMissing,
@@ -1121,6 +1122,7 @@ import {
     UnionType,
     UnionTypeNode,
     UniqueESSymbolType,
+    usesWildcardTypes,
     usingSingleLineStringWriter,
     VariableDeclaration,
     VariableDeclarationList,
@@ -4708,9 +4710,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
 
     function resolveExternalModuleName(location: Node, moduleReferenceExpression: Expression, ignoreErrors?: boolean, errorMessage?: DiagnosticMessage): Symbol | undefined {
         const isClassic = getEmitModuleResolutionKind(compilerOptions) === ModuleResolutionKind.Classic;
-        errorMessage ??= isClassic ?
+        errorMessage ??= getCannotResolveModuleNameErrorForSpecificModule(moduleReferenceExpression) ?? (isClassic ?
             Diagnostics.Cannot_find_module_0_Did_you_mean_to_set_the_moduleResolution_option_to_nodenext_or_to_add_aliases_to_the_paths_option
-            : Diagnostics.Cannot_find_module_0_or_its_corresponding_type_declarations;
+            : Diagnostics.Cannot_find_module_0_or_its_corresponding_type_declarations);
         return resolveExternalModuleNameWorker(location, moduleReferenceExpression, ignoreErrors ? undefined : errorMessage, ignoreErrors);
     }
 
@@ -27643,27 +27645,29 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
             case "console":
                 return Diagnostics.Cannot_find_name_0_Do_you_need_to_change_your_target_library_Try_changing_the_lib_compiler_option_to_include_dom;
             case "$":
-                return compilerOptions.types
-                    ? Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_jQuery_Try_npm_i_save_dev_types_Slashjquery_and_then_add_jquery_to_the_types_field_in_your_tsconfig
-                    : Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_jQuery_Try_npm_i_save_dev_types_Slashjquery;
+                return usesWildcardTypes(compilerOptions)
+                    ? Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_jQuery_Try_npm_i_save_dev_types_Slashjquery
+                    : Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_jQuery_Try_npm_i_save_dev_types_Slashjquery_and_then_add_jquery_to_the_types_field_in_your_tsconfig;
+            case "beforeEach":
             case "describe":
             case "suite":
             case "it":
             case "test":
-                return compilerOptions.types
-                    ? Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_a_test_runner_Try_npm_i_save_dev_types_Slashjest_or_npm_i_save_dev_types_Slashmocha_and_then_add_jest_or_mocha_to_the_types_field_in_your_tsconfig
-                    : Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_a_test_runner_Try_npm_i_save_dev_types_Slashjest_or_npm_i_save_dev_types_Slashmocha;
+                return usesWildcardTypes(compilerOptions)
+                    ? Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_a_test_runner_Try_npm_i_save_dev_types_Slashjest_or_npm_i_save_dev_types_Slashmocha
+                    : Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_a_test_runner_Try_npm_i_save_dev_types_Slashjest_or_npm_i_save_dev_types_Slashmocha_and_then_add_jest_or_mocha_to_the_types_field_in_your_tsconfig;
             case "process":
             case "require":
             case "Buffer":
             case "module":
-                return compilerOptions.types
-                    ? Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_node_Try_npm_i_save_dev_types_Slashnode_and_then_add_node_to_the_types_field_in_your_tsconfig
-                    : Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_node_Try_npm_i_save_dev_types_Slashnode;
+            case "NodeJS":
+                return usesWildcardTypes(compilerOptions)
+                    ? Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_node_Try_npm_i_save_dev_types_Slashnode
+                    : Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_node_Try_npm_i_save_dev_types_Slashnode_and_then_add_node_to_the_types_field_in_your_tsconfig;
             case "Bun":
-                return compilerOptions.types
-                    ? Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_Bun_Try_npm_i_save_dev_types_Slashbun_and_then_add_bun_to_the_types_field_in_your_tsconfig
-                    : Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_Bun_Try_npm_i_save_dev_types_Slashbun;
+                return usesWildcardTypes(compilerOptions)
+                    ? Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_Bun_Try_npm_i_save_dev_types_Slashbun
+                    : Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_Bun_Try_npm_i_save_dev_types_Slashbun_and_then_add_bun_to_the_types_field_in_your_tsconfig;
             case "Map":
             case "Set":
             case "Promise":
@@ -27698,6 +27702,20 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
         }
     }
 
+    function getCannotResolveModuleNameErrorForSpecificModule(moduleName: Expression): DiagnosticMessage | undefined {
+        if (moduleName.kind === SyntaxKind.StringLiteral) {
+            if (nodeCoreModules.has((moduleName as StringLiteral).text)) {
+                if (usesWildcardTypes(compilerOptions)) {
+                    return Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_node_Try_npm_i_save_dev_types_Slashnode;
+                }
+                else {
+                    return Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_node_Try_npm_i_save_dev_types_Slashnode_and_then_add_node_to_the_types_field_in_your_tsconfig;
+                }
+            }
+        }
+        return undefined;
+    }
+
     function getResolvedSymbol(node: Identifier): Symbol {
         const links = getNodeLinks(node);
         if (!links.resolvedSymbol) {

src/compiler/moduleNameResolver.ts

@@ -26,13 +26,15 @@ import {
     emptyArray,
     endsWith,
     ensureTrailingDirectorySeparator,
+    equateValues,
     every,
     Extension,
     extensionIsTS,
     fileExtensionIs,
     fileExtensionIsOneOf,
     filter,
     firstDefined,
+    flatten,
     forEach,
     forEachAncestorDirectory,
     formatMessage,
@@ -105,6 +107,7 @@ import {
     tryExtractTSExtension,
     tryGetExtensionFromPath,
     tryParsePatterns,
+    usesWildcardTypes,
     Version,
     version,
     versionMajorMinor,
@@ -803,18 +806,17 @@ export function resolvePackageNameToPackageJson(
  * Given a set of options, returns the set of type directive names
  *   that should be included for this program automatically.
  * This list could either come from the config file,
- *   or from enumerating the types root + initial secondary types lookup location.
+ *   and/or from enumerating the types root + initial secondary types lookup location given "*" compat wildcard.
  * More type directives might appear in the program later as a result of loading actual source files;
  *   this list is only the set of defaults that are implicitly included.
  */
 export function getAutomaticTypeDirectiveNames(options: CompilerOptions, host: ModuleResolutionHost): string[] {
-    // Use explicit type list from tsconfig.json
-    if (options.types) {
-        return options.types;
+    if (!usesWildcardTypes(options)) {
+        return options.types ?? [];
     }
 
     // Walk the primary type lookup locations
-    const result: string[] = [];
+    const wildcardMatches: string[] = [];
     if (host.directoryExists && host.getDirectories) {
         const typeRoots = getEffectiveTypeRoots(options, host);
         if (typeRoots) {
@@ -833,15 +835,18 @@ export function getAutomaticTypeDirectiveNames(options: CompilerOptions, host: M
                             // At this stage, skip results with leading dot.
                             if (baseFileName.charCodeAt(0) !== CharacterCodes.dot) {
                                 // Return just the type directive names
-                                result.push(baseFileName);
+                                wildcardMatches.push(baseFileName);
                             }
                         }
                     }
                 }
             }
         }
     }
-    return result;
+
+    // Order potentially matters in program construction, so substitute
+    // in the wildcard in the position it was specified in the types array
+    return deduplicate(flatten(options.types.map(t => t === "*" ? wildcardMatches : t)), equateValues);
 }
 
 export interface TypeReferenceDirectiveResolutionCache extends PerDirectoryResolutionCache<ResolvedTypeReferenceDirectiveWithFailedLookupLocations>, NonRelativeNameResolutionCache<ResolvedTypeReferenceDirectiveWithFailedLookupLocations>, PackageJsonInfoCache {

src/compiler/programDiagnostics.ts

@@ -52,6 +52,7 @@ import {
     removeSuffix,
     SourceFile,
     TsConfigSourceFile,
+    usesWildcardTypes,
 } from "./_namespaces/ts.js";
 
 interface FileReasonToChainCache {
@@ -400,8 +401,8 @@ export function createProgramDiagnostics(getCompilerOptionsObjectLiteralSyntax:
                     ) :
                     undefined;
             case FileIncludeKind.AutomaticTypeDirectiveFile:
-                if (!options.types) return undefined;
-                configFileNode = getOptionsSyntaxByArrayElementValue(getCompilerOptionsObjectLiteralSyntax(), "types", reason.typeReference);
+                configFileNode = getOptionsSyntaxByArrayElementValue(getCompilerOptionsObjectLiteralSyntax(), "types", usesWildcardTypes(options) ? "*" : reason.typeReference);
+
                 message = Diagnostics.File_is_entry_point_of_type_library_specified_here;
                 break;
             case FileIncludeKind.LibFile:

src/compiler/resolutionCache.ts

@@ -74,6 +74,7 @@ import {
     StringLiteralLike,
     trace,
     updateResolutionField,
+    usesWildcardTypes,
     WatchDirectoryFlags,
 } from "./_namespaces/ts.js";
 
@@ -1667,7 +1668,7 @@ export function createResolutionCache(resolutionHost: ResolutionCacheHost, rootD
      */
     function updateTypeRootsWatch() {
         const options = resolutionHost.getCompilationSettings();
-        if (options.types) {
+        if (!usesWildcardTypes(options)) {
             // No need to do any watch since resolution cache is going to handle the failed lookups
             // for the types added by this
             closeTypeRootsWatch();

src/compiler/utilities.ts

@@ -8971,6 +8971,14 @@ export function importSyntaxAffectsModuleResolution(options: CompilerOptions): b
         || getResolvePackageJsonImports(options);
 }
 
+/**
+ * @internal
+ * Returns true if this option's types array includes "*"
+ */
+export function usesWildcardTypes(options: CompilerOptions): options is CompilerOptions & { types: string[]; } {
+    return some(options.types, t => t === "*");
+}
+
 type CompilerOptionKeys = keyof { [K in keyof CompilerOptions as string extends K ? never : K]: any; };
 function createComputedCompilerOptions<T extends Record<string, CompilerOptionKeys[]>>(
     options: {

src/compiler/watch.ts

@@ -97,6 +97,7 @@ import {
     sourceMapCommentRegExpDontCareLineStart,
     sys,
     System,
+    usesWildcardTypes,
     WatchCompilerHost,
     WatchCompilerHostOfConfigFile,
     WatchCompilerHostOfFilesAndCompilerOptions,
@@ -529,7 +530,7 @@ export function fileIncludeReasonToDiagnostics(program: Program, reason: FileInc
                 options.outFile ? "--outFile" : "--out",
             );
         case FileIncludeKind.AutomaticTypeDirectiveFile: {
-            const messageAndArgs: DiagnosticAndArguments = options.types ?
+            const messageAndArgs: DiagnosticAndArguments = !usesWildcardTypes(options) ?
                 reason.packageId ?
                     [Diagnostics.Entry_point_of_type_library_0_specified_in_compilerOptions_with_packageId_1, reason.typeReference, packageIdToString(reason.packageId)] :
                     [Diagnostics.Entry_point_of_type_library_0_specified_in_compilerOptions, reason.typeReference] :

src/jsTyping/jsTyping.ts

@@ -28,6 +28,7 @@ import {
     some,
     toFileNameLowerCase,
     TypeAcquisition,
+    usesWildcardTypes,
     Version,
     versionMajorMinor,
 } from "./_namespaces/ts.js";
@@ -133,7 +134,7 @@ export function discoverTypings(
     const exclude = typeAcquisition.exclude || [];
 
     // Directories to search for package.json, bower.json and other typing information
-    if (!compilerOptions.types) {
+    if (!compilerOptions.types || usesWildcardTypes(compilerOptions)) {
         const possibleSearchDirs = new Set(fileNames.map(getDirectoryPath));
         possibleSearchDirs.add(projectRootPath);
         possibleSearchDirs.forEach(searchDir => {

src/services/codefixes/fixCannotFindModule.ts

@@ -27,6 +27,8 @@ const errorCannotFindImplicitJsxImport = Diagnostics.This_JSX_tag_requires_the_m
 const errorCodes = [
     errorCodeCannotFindModule,
     Diagnostics.Could_not_find_a_declaration_file_for_module_0_1_implicitly_has_an_any_type.code,
+    Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_node_Try_npm_i_save_dev_types_Slashnode.code,
+    Diagnostics.Cannot_find_name_0_Do_you_need_to_install_type_definitions_for_node_Try_npm_i_save_dev_types_Slashnode_and_then_add_node_to_the_types_field_in_your_tsconfig.code,
     errorCannotFindImplicitJsxImport,
 ];
 registerCodeFix({
@@ -77,7 +79,11 @@ function tryGetImportedPackageName(sourceFile: SourceFile, pos: number): string
 }
 
 function getTypesPackageNameToInstall(packageName: string, host: LanguageServiceHost, diagCode: number): string | undefined {
-    return diagCode === errorCodeCannotFindModule
-        ? (nodeCoreModules.has(packageName) ? "@types/node" : undefined)
-        : (host.isKnownTypesPackageName?.(packageName) ? getTypesPackageName(packageName) : undefined);
+    if (nodeCoreModules.has(packageName)) {
+        return "@types/node";
+    }
+    if (diagCode !== errorCodeCannotFindModule) {
+        return host.isKnownTypesPackageName?.(packageName) ? getTypesPackageName(packageName) : undefined;
+    }
+    return undefined;
 }

src/testRunner/unittests/tsbuild/moduleResolution.ts

@@ -78,13 +78,13 @@ describe("unittests:: tsbuild:: moduleResolution:: handles the modules and optio
             TestServerHost.createWatchedSystem({
                 "/home/src/workspaces/project/packages/pkg1_index.ts": `export const theNum: TheNum = "type1";`,
                 "/home/src/workspaces/project/packages/pkg1.tsconfig.json": jsonToReadableText({
-                    compilerOptions: { composite: true, typeRoots: ["./typeroot1"] },
+                    compilerOptions: { composite: true, typeRoots: ["./typeroot1"], types: ["*"] },
                     files: ["./pkg1_index.ts"],
                 }),
                 "/home/src/workspaces/project/packages/typeroot1/sometype/index.d.ts": dedent`declare type TheNum = "type1";`,
                 "/home/src/workspaces/project/packages/pkg2_index.ts": `export const theNum: TheNum2 = "type2";`,
                 "/home/src/workspaces/project/packages/pkg2.tsconfig.json": jsonToReadableText({
-                    compilerOptions: { composite: true, typeRoots: ["./typeroot2"] },
+                    compilerOptions: { composite: true, typeRoots: ["./typeroot2"], types: ["*"] },
                     files: ["./pkg2_index.ts"],
                 }),
                 "/home/src/workspaces/project/packages/typeroot2/sometype/index.d.ts": dedent`declare type TheNum2 = "type2";`,
@@ -163,7 +163,7 @@ describe("unittests:: tsbuild:: moduleResolution:: impliedNodeFormat differs bet
             TestServerHost.createWatchedSystem({
                 "/home/src/workspaces/project/a/src/index.ts": "",
                 "/home/src/workspaces/project/a/tsconfig.json": jsonToReadableText({
-                    compilerOptions: { strict: true },
+                    compilerOptions: { strict: true, types: ["*"] },
                 }),
                 "/home/src/workspaces/project/b/src/index.ts": dedent`
                     import pg from "pg";

src/testRunner/unittests/tsc/incremental.ts

@@ -188,7 +188,7 @@ declare global {
                     "/home/src/workspaces/project/node_modules/react/jsx-runtime.js": "export {}", // js needs to be present so there's a resolution result
                     "/home/src/workspaces/project/node_modules/@types/react/index.d.ts": getJsxLibraryContent(), // doesn't contain a jsx-runtime definition
                     "/home/src/workspaces/project/src/index.tsx": `export const App = () => <div propA={true}></div>;`,
-                    "/home/src/workspaces/project/tsconfig.json": jsonToReadableText({ compilerOptions: { module: "commonjs", jsx: "react-jsx", incremental: true, jsxImportSource: "react" } }),
+                    "/home/src/workspaces/project/tsconfig.json": jsonToReadableText({ compilerOptions: { module: "commonjs", jsx: "react-jsx", incremental: true, jsxImportSource: "react", types: ["react"] } }),
                 }),
             commandLineArgs: ts.emptyArray,
         });
@@ -201,7 +201,7 @@ declare global {
                     "/home/src/workspaces/project/node_modules/react/jsx-runtime.js": "export {}", // js needs to be present so there's a resolution result
                     "/home/src/workspaces/project/node_modules/@types/react/index.d.ts": getJsxLibraryContent(), // doesn't contain a jsx-runtime definition
                     "/home/src/workspaces/project/src/index.tsx": `export const App = () => <div propA={true}></div>;`,
-                    "/home/src/workspaces/project/tsconfig.json": jsonToReadableText({ compilerOptions: { module: "commonjs", jsx: "react-jsx", incremental: true, jsxImportSource: "react" } }),
+                    "/home/src/workspaces/project/tsconfig.json": jsonToReadableText({ compilerOptions: { module: "commonjs", jsx: "react-jsx", incremental: true, jsxImportSource: "react", types: ["react"] } }),
                 }),
             commandLineArgs: ["--strict"],
         });