fix: ensure ts source file with no-default-lib that augments the global scope gets emitted with incremental program (#48412)

* fix: do not classify non-declaration files as default library source files

* Add test.

Author: dsherret

src/compiler/program.ts

@@ -1958,6 +1958,10 @@ namespace ts {
         }
 
         function isSourceFileDefaultLibrary(file: SourceFile): boolean {
+            if (!file.isDeclarationFile) {
+                return false;
+            }
+
             if (file.hasNoDefaultLib) {
                 return true;
             }

src/testRunner/unittests/tsc/incremental.ts

@@ -449,5 +449,36 @@ declare global {
             }, `\ninterface ReadonlyArray<T> { readonly length: number }`),
             incrementalScenarios: noChangeOnlyRuns,
         });
+
+        verifyTsc({
+            scenario: "incremental",
+            subScenario: "ts file with no-default-lib that augments the global scope",
+            fs: () => loadProjectFromFiles({
+                "/src/project/src/main.ts": Utils.dedent`
+                    /// <reference no-default-lib="true"/>
+                    /// <reference lib="esnext" />
+
+                    declare global {
+                        interface Test {
+                        }
+                    }
+
+                    export {};
+                `,
+                "/src/project/tsconfig.json": Utils.dedent`
+                    {
+                        "compilerOptions": {
+                            "target": "ESNext",
+                            "module": "ESNext",
+                            "incremental": true,
+                            "outDir": "dist",
+                        },
+                    }`,
+            }),
+            commandLineArgs: ["--p", "src/project", "--rootDir", "src/project/src"],
+            modifyFs: (fs) => {
+                fs.writeFileSync("/lib/lib.esnext.d.ts", libContent);
+            }
+        });
     });
 }

tests/baselines/reference/tsc/incremental/initial-build/ts-file-with-no-default-lib-that-augments-the-global-scope.js

@@ -0,0 +1,93 @@
+Input::
+//// [/lib/lib.d.ts]
+
+
+//// [/lib/lib.esnext.d.ts]
+/// <reference no-default-lib="true"/>
+interface Boolean {}
+interface Function {}
+interface CallableFunction {}
+interface NewableFunction {}
+interface IArguments {}
+interface Number { toExponential: any; }
+interface Object {}
+interface RegExp {}
+interface String { charAt: any; }
+interface Array<T> { length: number; [n: number]: T; }
+interface ReadonlyArray<T> {}
+declare const console: { log(msg: any): void; };
+
+//// [/src/project/src/main.ts]
+/// <reference no-default-lib="true"/>
+/// <reference lib="esnext" />
+
+declare global {
+    interface Test {
+    }
+}
+
+export {};
+
+
+//// [/src/project/tsconfig.json]
+{
+    "compilerOptions": {
+        "target": "ESNext",
+        "module": "ESNext",
+        "incremental": true,
+        "outDir": "dist",
+    },
+}
+
+
+
+Output::
+/lib/tsc --p src/project --rootDir src/project/src
+exitCode:: ExitStatus.Success
+
+
+//// [/src/project/dist/main.js]
+/// <reference no-default-lib="true"/>
+/// <reference lib="esnext" />
+export {};
+
+
+//// [/src/project/tsconfig.tsbuildinfo]
+{"program":{"fileNames":["../../lib/lib.esnext.d.ts","./src/main.ts"],"fileInfos":[{"version":"3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };","affectsGlobalScope":true},{"version":"-2443389309-/// <reference no-default-lib=\"true\"/>\n/// <reference lib=\"esnext\" />\n\ndeclare global {\n    interface Test {\n    }\n}\n\nexport {};\n","affectsGlobalScope":true}],"options":{"module":99,"outDir":"./dist","rootDir":"./src","target":99},"referencedMap":[],"exportedModulesMap":[],"semanticDiagnosticsPerFile":[1,2]},"version":"FakeTSVersion"}
+
+//// [/src/project/tsconfig.tsbuildinfo.readable.baseline.txt]
+{
+  "program": {
+    "fileNames": [
+      "../../lib/lib.esnext.d.ts",
+      "./src/main.ts"
+    ],
+    "fileInfos": {
+      "../../lib/lib.esnext.d.ts": {
+        "version": "3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };",
+        "signature": "3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };",
+        "affectsGlobalScope": true
+      },
+      "./src/main.ts": {
+        "version": "-2443389309-/// <reference no-default-lib=\"true\"/>\n/// <reference lib=\"esnext\" />\n\ndeclare global {\n    interface Test {\n    }\n}\n\nexport {};\n",
+        "signature": "-2443389309-/// <reference no-default-lib=\"true\"/>\n/// <reference lib=\"esnext\" />\n\ndeclare global {\n    interface Test {\n    }\n}\n\nexport {};\n",
+        "affectsGlobalScope": true
+      }
+    },
+    "options": {
+      "module": 99,
+      "outDir": "./dist",
+      "rootDir": "./src",
+      "target": 99
+    },
+    "referencedMap": {},
+    "exportedModulesMap": {},
+    "semanticDiagnosticsPerFile": [
+      "../../lib/lib.esnext.d.ts",
+      "./src/main.ts"
+    ]
+  },
+  "version": "FakeTSVersion",
+  "size": 935
+}
+