Don't defer index types for non-generic substitution types #61999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that index types on non-generic substitution types are resolved immediately (instead of deferred), addressing #61728.
- Added two new compiler tests to verify index lookups on non-generic substitution types.
- Modified
getIndexTypeinchecker.tsto bypass deferral when bothbaseTypeandconstraintare non-generic.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/cases/compiler/substitutionTypeNonGenericIndexType1.ts | Adds a test for boolean conditional index resolution on non-generic substitution types. |
| tests/cases/compiler/substitutionTypeNonGenericIndexType2.ts | Adds a test for infer-based index resolution on non-generic substitution types. |
| src/compiler/checker.ts | Updates getIndexType to immediately compute index types for non-generic substitutions. |
Comments suppressed due to low confidence (3)
tests/cases/compiler/substitutionTypeNonGenericIndexType2.ts:1
- [nitpick] Consider adding a reference to GitHub issue #61728 at the top of this test for consistency with related test files.
// @strict: true
tests/cases/compiler/substitutionTypeNonGenericIndexType2.ts:14
- [nitpick] Consider adding additional test cases where either the
baseTypeor theconstraintis generic to ensure this new index type logic covers mixed generic scenarios.
const test: Test["rejectClose"] = "rejectClose";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #61728