fix: Fix masking in single element screenshots. #1825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using masks in single element screenshots (`Locator.screenshot()`) never worked, because the mask option failed to be serialized. When a mask is provided as an option, serialize it manually. This is the same implementation as in `PageImpl.screenshot()`. Fixes microsoft#1790
|
@microsoft-github-policy-service agree company="Medartis AG" |
yury-s
reviewed
Aug 1, 2025
| " }\n" + | ||
| " </style>\n" + | ||
| " <div contenteditable=\"true\"></div>\n"); | ||
| " stylesheet rules will throw.\n" + |
There was a problem hiding this comment.
Please revert the formatting changes.
| @@ -304,13 +315,13 @@ public void scrollIntoViewIfNeeded(ScrollIntoViewIfNeededOptions options) { | |||
|
|
|||
| @Override | |||
| public List<String> selectOption(String value, SelectOptionOptions options) { | |||
| String[] values = value == null ? null : new String[]{ value }; | |||
| String[] values = value == null ? null : new String[]{value}; | |||
There was a problem hiding this comment.
Please revert code formatting changes here and in other places, they just clutter the PR.
| if (mask != null) { | ||
| JsonArray maskArray = new JsonArray(); | ||
| for (Locator locator : mask) { | ||
| maskArray.add(((LocatorImpl) locator).toProtocol()); |
There was a problem hiding this comment.
Instead of duplicating code with PageImpl, let's add a serializer for LocatorImpl.class into Serialization.java, that way it will automatically work for Locator.screenshot, ElementHandle.screenshot and Page.screenshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using masks in single element screenshots (
Locator.screenshot()) never worked, because the mask option failed to be serialized.When a mask is provided as an option, serialize it manually. This is the same implementation as in
PageImpl.screenshot().Fixes #1790