diff --git a/.nx/version-plans/version-plan-1753834774679.md b/.nx/version-plans/version-plan-1753834774679.md new file mode 100644 index 00000000000000..ab4a6a5b73c71b --- /dev/null +++ b/.nx/version-plans/version-plan-1753834774679.md @@ -0,0 +1,5 @@ +--- +__default__: patch +--- + +Implement paused in Debugger overlay diff --git a/packages/react-native/React/CoreModules/RCTLogBoxView.mm b/packages/react-native/React/CoreModules/RCTLogBoxView.mm index 11656eb45330ba..3a35e31bd81bb8 100644 --- a/packages/react-native/React/CoreModules/RCTLogBoxView.mm +++ b/packages/react-native/React/CoreModules/RCTLogBoxView.mm @@ -79,7 +79,10 @@ - (instancetype)initWithWindow:(RCTUIWindow *)window surfacePresenter:(id_alertWindow]) { + [parentWindow beginSheet:self.alertWindow completionHandler:^(NSModalResponse returnCode) { + [self->_alertWindow orderOut:self]; + }]; + } +#endif // macOS] } - (void)hide @@ -136,9 +194,19 @@ - (void)hide [_alertWindow setHidden:YES]; _alertWindow.windowScene = nil; +#else // [macOS] + NSWindow *parentWindow = RCTKeyWindow(); + if (parentWindow) { + for (NSWindow *sheet in [parentWindow sheets]) { + if (sheet == _alertWindow) { + [parentWindow endSheet:sheet]; + break; + } + } + } +#endif // macOS] _alertWindow = nil; -#endif // macOS] } @end diff --git a/packages/rn-tester/Podfile b/packages/rn-tester/Podfile index 36de2659c76c89..ddc6190c0f09ea 100644 --- a/packages/rn-tester/Podfile +++ b/packages/rn-tester/Podfile @@ -39,8 +39,7 @@ def pods(target_name, options = {}) # Hermes is now enabled by default. # The following line will only disable Hermes if the USE_HERMES envvar is SET to a value other than 1 (e.g. USE_HERMES=0). - # [macOS] Make hermes disabled by default for our fork - hermes_enabled = ENV['USE_HERMES'] == '1' + hermes_enabled = !ENV.has_key?('USE_HERMES') || ENV['USE_HERMES'] == '1' puts "Configuring #{target_name} with Fabric #{fabric_enabled ? "enabled" : "disabled"}.#{hermes_enabled ? " Using Hermes engine." : ""}" use_react_native!(