tsc -b

Author: sheetalkamat

cmd/tsgo/sys.go

@@ -45,11 +45,6 @@ func (s *osSys) Writer() io.Writer {
 	return s.writer
 }
 
-func (s *osSys) EndWrite() {
-	// do nothing, this is needed in the interface for testing
-	// todo: revisit if improving tsc/build/watch unittest baselines
-}
-
 func newSystem() *osSys {
 	cwd, err := os.Getwd()
 	if err != nil {

internal/api/server.go

@@ -8,6 +8,7 @@ import (
 	"io"
 	"strconv"
 	"sync"
+	"time"
 
 	"github.com/go-json-experiment/json"
 	"github.com/microsoft/typescript-go/internal/bundled"
@@ -472,3 +473,8 @@ func (s *Server) Stat(path string) vfs.FileInfo {
 func (s *Server) Remove(path string) error {
 	panic("unimplemented")
 }
+
+// Chtimes implements vfs.FS.
+func (s *Server) Chtimes(path string, aTime time.Time, mTime time.Time) error {
+	panic("unimplemented")
+}

internal/bundled/embed.go

@@ -161,6 +161,13 @@ func (vfs *wrappedFS) Remove(path string) error {
 	return vfs.fs.Remove(path)
 }
 
+func (vfs *wrappedFS) Chtimes(path string, aTime time.Time, mTime time.Time) error {
+	if _, ok := splitPath(path); ok {
+		panic("cannot change times on embedded file system")
+	}
+	return vfs.fs.Chtimes(path, aTime, mTime)
+}
+
 type fileInfo struct {
 	mode fs.FileMode
 	name string

internal/compiler/emitter.go

@@ -42,9 +42,6 @@ type emitter struct {
 }
 
 func (e *emitter) emit() {
-	if e.host.Options().ListEmittedFiles.IsTrue() {
-		e.emitResult.EmittedFiles = []string{}
-	}
 	// !!! tracing
 	e.emitJSFile(e.sourceFile, e.paths.JsFilePath(), e.paths.SourceMapFilePath())
 	e.emitDeclarationFile(e.sourceFile, e.paths.DeclarationFilePath(), e.paths.DeclarationMapPath())
@@ -254,7 +251,7 @@ func (e *emitter) printSourceFile(jsFilePath string, sourceMapFilePath string, s
 			err := e.host.WriteFile(sourceMapFilePath, sourceMap, false /*writeByteOrderMark*/)
 			if err != nil {
 				e.emitterDiagnostics.Add(ast.NewCompilerDiagnostic(diagnostics.Could_not_write_file_0_Colon_1, jsFilePath, err.Error()))
-			} else if e.emitResult.EmittedFiles != nil {
+			} else {
 				e.emitResult.EmittedFiles = append(e.emitResult.EmittedFiles, sourceMapFilePath)
 			}
 		}
@@ -278,7 +275,7 @@ func (e *emitter) printSourceFile(jsFilePath string, sourceMapFilePath string, s
 	}
 	if err != nil {
 		e.emitterDiagnostics.Add(ast.NewCompilerDiagnostic(diagnostics.Could_not_write_file_0_Colon_1, jsFilePath, err.Error()))
-	} else if e.emitResult.EmittedFiles != nil && !skippedDtsWrite {
+	} else if !skippedDtsWrite {
 		e.emitResult.EmittedFiles = append(e.emitResult.EmittedFiles, jsFilePath)
 	}
 

internal/compiler/fileloader.go

@@ -567,11 +567,6 @@ func getInferredLibraryNameResolveFrom(options *core.CompilerOptions, currentDir
 	return tspath.CombinePaths(containingDirectory, "__lib_node_modules_lookup_"+libFileName+"__.ts")
 }
 
-type resolution struct {
-	node           *ast.Node
-	resolvedModule *module.ResolvedModule
-}
-
 func getModeForTypeReferenceDirectiveInFile(ref *ast.FileReference, file *ast.SourceFile, meta ast.SourceFileMetaData, options *core.CompilerOptions) core.ResolutionMode {
 	if ref.ResolutionMode != core.ResolutionModeNone {
 		return ref.ResolutionMode

internal/compiler/program.go

@@ -257,6 +257,7 @@ func equalCheckJSDirectives(d1 *ast.CheckJsDirective, d2 *ast.CheckJsDirective)
 
 func (p *Program) SourceFiles() []*ast.SourceFile { return p.files }
 func (p *Program) Options() *core.CompilerOptions { return p.opts.Config.CompilerOptions() }
+func (p *Program) GetRootFileNames() []string     { return p.opts.Config.FileNames() }
 func (p *Program) Host() CompilerHost             { return p.opts.Host }
 func (p *Program) GetConfigFileParsingDiagnostics() []*ast.Diagnostic {
 	return slices.Clip(p.opts.Config.GetConfigFileParsingDiagnostics())
@@ -1353,9 +1354,7 @@ func CombineEmitResults(results []*EmitResult) *EmitResult {
 			result.EmitSkipped = true
 		}
 		result.Diagnostics = append(result.Diagnostics, emitResult.Diagnostics...)
-		if emitResult.EmittedFiles != nil {
-			result.EmittedFiles = append(result.EmittedFiles, emitResult.EmittedFiles...)
-		}
+		result.EmittedFiles = append(result.EmittedFiles, emitResult.EmittedFiles...)
 		if emitResult.SourceMaps != nil {
 			result.SourceMaps = append(result.SourceMaps, emitResult.SourceMaps...)
 		}

internal/compiler/projectreferencedtsfakinghost.go

@@ -2,6 +2,7 @@ package compiler
 
 import (
 	"strings"
+	"time"
 
 	"github.com/microsoft/typescript-go/internal/collections"
 	"github.com/microsoft/typescript-go/internal/core"
@@ -87,6 +88,11 @@ func (fs *projectReferenceDtsFakingVfs) Remove(path string) error {
 	panic("should not be called by resolver")
 }
 
+// Chtimes implements vfs.FS.
+func (fs *projectReferenceDtsFakingVfs) Chtimes(path string, aTime time.Time, mTime time.Time) error {
+	panic("should not be called by resolver")
+}
+
 // DirectoryExists implements vfs.FS.
 func (fs *projectReferenceDtsFakingVfs) DirectoryExists(path string) bool {
 	if fs.projectReferenceFileMapper.opts.Host.FS().DirectoryExists(path) {

internal/diagnostics/diagnostics_generated.go

@@ -22,5 +22,21 @@
     "A JSDoc '@type' tag may not occur with a '@param' or '@returns' tag.": {
         "category": "Error",
         "code": 8040
+    },
+    "Failed to delete file '{0}'.": {
+        "category": "Message",
+        "code": 6353
+    },
+    "Project '{0}' is out of date because config file does not exist.": {
+        "category": "Message",
+        "code": 6401
+    },
+    "Project '{0}' is out of date because input '{1}' does not exist.": {
+        "category": "Message",
+        "code": 6420
+    },
+    "Failed to update timestamp of file '{0}'.": {
+        "category": "Message",
+        "code": 5074
     }
 }

internal/diagnostics/extraDiagnosticMessages.json

@@ -21,7 +21,7 @@ type FormattingOptions struct {
 }
 
 const (
-	foregroundColorEscapeGrey   = "\u001b[90m"
+	ForegroundColorEscapeGrey   = "\u001b[90m"
 	foregroundColorEscapeRed    = "\u001b[91m"
 	foregroundColorEscapeYellow = "\u001b[93m"
 	foregroundColorEscapeBlue   = "\u001b[94m"
@@ -39,43 +39,45 @@ func FormatDiagnosticsWithColorAndContext(output io.Writer, diags []*ast.Diagnos
 	if len(diags) == 0 {
 		return
 	}
-
 	for i, diagnostic := range diags {
 		if i > 0 {
 			fmt.Fprint(output, formatOpts.NewLine)
 		}
+		FormatDiagnosticWithColorAndContext(output, diagnostic, formatOpts)
+	}
+}
 
-		if diagnostic.File() != nil {
-			file := diagnostic.File()
-			pos := diagnostic.Loc().Pos()
-			WriteLocation(output, file, pos, formatOpts, writeWithStyleAndReset)
-			fmt.Fprint(output, " - ")
-		}
+func FormatDiagnosticWithColorAndContext(output io.Writer, diagnostic *ast.Diagnostic, formatOpts *FormattingOptions) {
+	if diagnostic.File() != nil {
+		file := diagnostic.File()
+		pos := diagnostic.Loc().Pos()
+		WriteLocation(output, file, pos, formatOpts, writeWithStyleAndReset)
+		fmt.Fprint(output, " - ")
+	}
 
-		writeWithStyleAndReset(output, diagnostic.Category().Name(), getCategoryFormat(diagnostic.Category()))
-		fmt.Fprintf(output, "%s TS%d: %s", foregroundColorEscapeGrey, diagnostic.Code(), resetEscapeSequence)
-		WriteFlattenedDiagnosticMessage(output, diagnostic, formatOpts.NewLine)
+	writeWithStyleAndReset(output, diagnostic.Category().Name(), getCategoryFormat(diagnostic.Category()))
+	fmt.Fprintf(output, "%s TS%d: %s", ForegroundColorEscapeGrey, diagnostic.Code(), resetEscapeSequence)
+	WriteFlattenedDiagnosticMessage(output, diagnostic, formatOpts.NewLine)
 
-		if diagnostic.File() != nil && diagnostic.Code() != diagnostics.File_appears_to_be_binary.Code() {
-			fmt.Fprint(output, formatOpts.NewLine)
-			writeCodeSnippet(output, diagnostic.File(), diagnostic.Pos(), diagnostic.Len(), getCategoryFormat(diagnostic.Category()), "", formatOpts)
-			fmt.Fprint(output, formatOpts.NewLine)
-		}
+	if diagnostic.File() != nil && diagnostic.Code() != diagnostics.File_appears_to_be_binary.Code() {
+		fmt.Fprint(output, formatOpts.NewLine)
+		writeCodeSnippet(output, diagnostic.File(), diagnostic.Pos(), diagnostic.Len(), getCategoryFormat(diagnostic.Category()), "", formatOpts)
+		fmt.Fprint(output, formatOpts.NewLine)
+	}
 
-		if (diagnostic.RelatedInformation() != nil) && (len(diagnostic.RelatedInformation()) > 0) {
-			for _, relatedInformation := range diagnostic.RelatedInformation() {
-				file := relatedInformation.File()
-				if file != nil {
-					fmt.Fprint(output, formatOpts.NewLine)
-					fmt.Fprint(output, "  ")
-					pos := relatedInformation.Pos()
-					WriteLocation(output, file, pos, formatOpts, writeWithStyleAndReset)
-					fmt.Fprint(output, " - ")
-					WriteFlattenedDiagnosticMessage(output, relatedInformation, formatOpts.NewLine)
-					writeCodeSnippet(output, file, pos, relatedInformation.Len(), foregroundColorEscapeCyan, "    ", formatOpts)
-				}
+	if (diagnostic.RelatedInformation() != nil) && (len(diagnostic.RelatedInformation()) > 0) {
+		for _, relatedInformation := range diagnostic.RelatedInformation() {
+			file := relatedInformation.File()
+			if file != nil {
 				fmt.Fprint(output, formatOpts.NewLine)
+				fmt.Fprint(output, "  ")
+				pos := relatedInformation.Pos()
+				WriteLocation(output, file, pos, formatOpts, writeWithStyleAndReset)
+				fmt.Fprint(output, " - ")
+				WriteFlattenedDiagnosticMessage(output, relatedInformation, formatOpts.NewLine)
+				writeCodeSnippet(output, file, pos, relatedInformation.Len(), foregroundColorEscapeCyan, "    ", formatOpts)
 			}
+			fmt.Fprint(output, formatOpts.NewLine)
 		}
 	}
 }
@@ -196,7 +198,7 @@ func getCategoryFormat(category diagnostics.Category) string {
 	case diagnostics.CategoryWarning:
 		return foregroundColorEscapeYellow
 	case diagnostics.CategorySuggestion:
-		return foregroundColorEscapeGrey
+		return ForegroundColorEscapeGrey
 	case diagnostics.CategoryMessage:
 		return foregroundColorEscapeBlue
 	}
@@ -359,7 +361,7 @@ func prettyPathForFileError(file *ast.SourceFile, fileErrors []*ast.Diagnostic,
 	}
 	return fmt.Sprintf("%s%s:%d%s",
 		fileName,
-		foregroundColorEscapeGrey,
+		ForegroundColorEscapeGrey,
 		line+1,
 		resetEscapeSequence,
 	)
@@ -383,3 +385,15 @@ func WriteFormatDiagnostic(output io.Writer, diagnostic *ast.Diagnostic, formatO
 	WriteFlattenedDiagnosticMessage(output, diagnostic, formatOpts.NewLine)
 	fmt.Fprint(output, formatOpts.NewLine)
 }
+
+func FormatDiagnosticsStatusWithColorAndTime(output io.Writer, time string, diag *ast.Diagnostic, formatOpts *FormattingOptions) {
+	fmt.Fprint(output, "[")
+	writeWithStyleAndReset(output, time, ForegroundColorEscapeGrey)
+	fmt.Fprint(output, "] ")
+	WriteFlattenedDiagnosticMessage(output, diag, formatOpts.NewLine)
+}
+
+func FormatDiagnosticsStatusAndTime(output io.Writer, time string, diag *ast.Diagnostic, formatOpts *FormattingOptions) {
+	fmt.Fprint(output, time, " - ")
+	WriteFlattenedDiagnosticMessage(output, diag, formatOpts.NewLine)
+}