Mock process before importing #8626
Conversation
microsoft-github-policy-service
bot
added
the
compiler:core
| compilerHost: NodeHost, | ||
| compilerHost: { | ||
| ...NodeHost, | ||
| getJsImport: (path: string) => { |
There was a problem hiding this comment.
only doing this in the server right now but feels like this probably should just be in the NodeHost because right now the repro will let tsp compile stuck
commit: |
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
|
You can try these changes here
|
| const result = NodeHost.getJsImport(path); | ||
| return result; | ||
| } finally { | ||
| globalThis.process.stdin = oldProcess.stdin; |
| let result: any; | ||
| process.exit = (() => { | ||
| // for module that calls process.exit when being imported, create an empty object as it's exports to avoid load it again | ||
| result = {}; |
There was a problem hiding this comment.
it's better for loadJsFile to return a mock result or throw so that the caller can do something for the "bad" lib. otherwise, cache won't work for these "bad" lib and we will keep loading the "bad" lib every time unnecessary.
microsoft-github-policy-service
bot
added
the
stale
|
Hi @@timotheeguerin. Your PR has had no update for 30 days and it is marked as a stale PR. If it is not updated within 30 days, the PR will automatically be closed. If you want to refresh the PR, please remove the |
4 participants
fix #8624
To prevent bad packages from corrupting the language server mock the process which is something you shouldn't be using anyway