Address PR feedback

Author: Colengms

Extension/src/Debugger/configurationProvider.ts

@@ -546,20 +546,14 @@ export class DebugConfigurationProvider implements vscode.DebugConfigurationProv
             return;
         }
 
-        const fileExt: string = path.extname(editor.document.fileName);
-        if (!fileExt) {
-            DebugConfigurationProvider.detectedBuildTasks = emptyTasks;
-            return;
-        }
-
         // Don't offer tasks for header files.
         const isHeader: boolean = util.isHeaderFile(editor.document.uri);
         if (isHeader) {
             DebugConfigurationProvider.detectedBuildTasks = emptyTasks;
             return;
         }
 
-        // Don't offer tasks if the active file's extension is not a recognized C/C++ extension.
+        // Don't offer tasks if the active file is not a recognized C/C++ source file.
         const fileIsCpp: boolean = util.isCppFile(editor.document.uri, editor.document.languageId);
         const fileIsC: boolean = util.isCFile(editor.document.uri, editor.document.languageId);
         if (!(fileIsCpp || fileIsC)) {

Extension/src/LanguageServer/cppBuildTaskProvider.ts

@@ -73,26 +73,21 @@ export class CppBuildTaskProvider implements TaskProvider {
         return _task;
     }
 
-    // Generate tasks to build the current file based on the user's detected compilers, the user's compilerPath setting, and the current file's extension.
+    // Generate tasks to build the current file based on the user's detected compilers, compilerPath setting, and file type.
     public async getTasks(appendSourceToName: boolean = false): Promise<CppBuildTask[]> {
         const editor: TextEditor | undefined = window.activeTextEditor;
         const emptyTasks: CppBuildTask[] = [];
         if (!editor) {
             return emptyTasks;
         }
 
-        const fileExt: string = path.extname(editor.document.fileName);
-        if (!fileExt) {
-            return emptyTasks;
-        }
-
         // Don't offer tasks for header files.
         const isHeader: boolean = util.isHeaderFile(editor.document.uri);
         if (isHeader) {
             return emptyTasks;
         }
 
-        // Don't offer tasks if the active file's extension is not a recognized C/C++ extension.
+        // Don't offer tasks if the active file is not a recognized C/C++ source file.
         const fileIsCpp: boolean = util.isCppFile(editor.document.uri, editor.document.languageId);
         const fileIsC: boolean = util.isCFile(editor.document.uri, editor.document.languageId);
         if (!(fileIsCpp || fileIsC)) {

Extension/test/unit/fileType.test.ts

@@ -53,6 +53,7 @@ describe('file type mappings', () => {
             ],
             filenames: [
                 { name: 'foo.h', kind: 'source', language: 'c' },
+                { name: 'build', kind: 'source', language: 'cpp' },
                 { name: 'vector', kind: 'header' },
                 { name: 'kernel.custom', kind: 'source', language: 'cuda' }
             ]
@@ -62,11 +63,13 @@ describe('file type mappings', () => {
         deepStrictEqual(classifyFilePath('module.CPPM'), { name: '.cppm', kind: 'source', language: 'cpp' });
         deepStrictEqual(classifyFilePath('file.C'), { name: '.C', kind: 'source', language: 'cpp' });
         deepStrictEqual(classifyFilePath('foo.h'), { name: 'foo.h', kind: 'source', language: 'c' });
+        deepStrictEqual(classifyFilePath('build'), { name: 'build', kind: 'source', language: 'cpp' });
         deepStrictEqual(classifyFilePath('VECTOR'), { name: 'vector', kind: 'header' });
         deepStrictEqual(classifyFilePath('kernel.custom'), { name: 'kernel.custom', kind: 'source', language: 'cuda' });
         equal(classifyFilePath('Makefile'), undefined);
         equal(isTagParsableFile('schema.idl'), true);
         equal(isTagParsableFile('kernel.custom'), true);
+        equal(isTagParsableFile('build'), true);
         equal(isTagParsableFile('vector'), true);
         equal(isTagParsableFile('unknown.txt'), false);
     });
@@ -96,5 +99,6 @@ describe('file type mappings', () => {
         deepStrictEqual(classifyFilePath('file.h', 'c'), { name: '.h', kind: 'header', language: 'cpp' });
         deepStrictEqual(classifyFilePath('file.special', 'c'), { name: '', kind: 'source', language: 'c' });
         deepStrictEqual(classifyFilePath('file.special', 'cuda-cpp'), { name: '', kind: 'source', language: 'cuda' });
+        deepStrictEqual(classifyFilePath('extensionless', 'cpp'), { name: '', kind: 'source', language: 'cpp' });
     });
 });