Make mark PRs as done less expensive

Author: alexr00

src/github/pullRequestModel.ts

@@ -904,6 +904,31 @@ export class PullRequestModel extends IssueModel<PullRequest> implements IPullRe
 		return events;
 	}
 
+	async getActivityTimelineEvents(): Promise<TimelineEvent[]> {
+		Logger.debug(`Fetch timeline events of PR #${this.number} - enter`, PullRequestModel.ID);
+		const { query, remote, schema } = await this.githubRepository.ensure();
+		try {
+			const { data } = await query<TimelineEventsResponse>({
+				query: schema.PullRequestActivityTimelineEvents,
+				variables: {
+					owner: remote.owner,
+					name: remote.repositoryName,
+					number: this.number,
+				},
+			});
+
+			if (data.repository === null) {
+				Logger.error('Unexpected null repository when fetching timeline', PullRequestModel.ID);
+			}
+
+			return parseCombinedTimelineEvents(data.repository?.pullRequest.timelineItems.nodes ?? [], [], this.githubRepository);
+		} catch (e) {
+			Logger.error(`Failed to get pull request timeline events: ${e}`, PullRequestModel.ID);
+			console.log(e);
+			return [];
+		}
+	}
+
 	private addReviewTimelineEventComments(events: TimelineEvent[], reviewThreads: IReviewThread[]): void {
 		interface CommentNode extends IComment {
 			childComments?: CommentNode[];

src/github/queriesShared.gql

@@ -321,6 +321,26 @@ query TimelineEvents($owner: String!, $name: String!, $number: Int!, $last: Int
 	}
 }
 
+query PullRequestActivityTimelineEvents($owner: String!, $name: String!, $number: Int!, $last: Int = 5) {
+	repository(owner: $owner, name: $name) {
+		pullRequest(number: $number) {
+			timelineItems(last: $last) {
+				nodes {
+					__typename
+					...Merged
+					...Comment
+					...Review
+					...Commit
+					...ClosedEvent
+				}
+			}
+		}
+	}
+	rateLimit {
+		...RateLimit
+	}
+}
+
 query IssueTimelineEvents($owner: String!, $name: String!, $number: Int!, $last: Int = 150) {
 	repository(owner: $owner, name: $name) {
 		pullRequest: issue(number: $number) {

src/notifications/notificationsManager.ts

@@ -371,15 +371,15 @@ export class NotificationsManager extends Disposable implements vscode.TreeDataP
 
 	public async markPullRequests(markAsDone: boolean = false): Promise<void> {
 		const filteredNotifications = Array.from(this._notifications.values()).filter(notification => notification.notification.subject.type === NotificationSubjectType.PullRequest);
-		const timlines = await Promise.all(filteredNotifications.map(notification => (notification.model as PullRequestModel).getTimelineEvents()));
+		const timelines = await Promise.all(filteredNotifications.map(notification => (notification.model as PullRequestModel).getActivityTimelineEvents()));
 
 		const markPromises: Promise<void>[] = [];
 
 		for (const [index, notification] of filteredNotifications.entries()) {
 			const currentUser = await this._credentialStore.getCurrentUser(notification.model.remote.authProviderId);
 
 			// Check that there have been no comments, reviews, or commits, since last read
-			const timeline = timlines[index];
+			const timeline = timelines[index];
 			let userLastEvent: Date | undefined = undefined;
 			let nonUserLastEvent: Date | undefined = undefined;
 			for (let i = timeline.length - 1; i >= 0; i--) {