-
Notifications
You must be signed in to change notification settings - Fork 338
[main] Source code updates from dotnet/dotnet #15110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.631904 -> 0.2.631905)
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.631905 -> 0.2.632106)
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.632106 -> 0.2.632118)
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.632118 -> 0.2.632402)
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.632402 -> 0.2.632503)
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.632503 -> 0.2.0-preview.25325.106)
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25325.106 -> 0.2.0-preview.25326.109)
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25326.109 -> 0.2.0-preview.25327.102)
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25327.102 -> 0.2.0-preview.25330.103)
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25330.103 -> 0.2.0-preview.25351.105)
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25351.105 -> 0.2.0-preview.25351.106)
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25351.106 -> 0.2.0-preview.25358.102)
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25358.102 -> 0.2.0-preview.25359.101)
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25359.101 -> 0.2.0-preview.25360.101)
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25360.101 -> 0.2.0-preview.25362.103)
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25362.103 -> 0.2.0-preview.25363.101)
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25363.101 -> 0.2.0-preview.25364.102)
update from dotnet/dotnet updated us to the 0.2.xxx version, and now it is trying to downgrade, did the versioning change and this is now safe to merge @ViktorHofer ? |
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25364.102 -> 0.2.0-preview.25365.101)
This was introduced in dotnet/dotnet#1317. I wonder if you should be consuming the package from the dotnet/diagnostics build instead of the VMR build cause it seems you're redistributing it. @mmitche |
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25365.101 -> 0.2.0-preview.25366.103)
Dug through some more Teams history and this should be fine precisely because you're only redistributing it inside another package (not as a transitive reference) so the version number doesn't really matter, it's basically just a transport package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay to downgrade, per comments above.
Note
This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos