Skip to content

[main] Source code updates from dotnet/dotnet #15110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 17, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 20, 2025

dotnet-maestro bot added 13 commits June 20, 2025 02:06
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.631904 -> 0.2.631905)
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.631905 -> 0.2.632106)
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.632106 -> 0.2.632118)
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.632118 -> 0.2.632402)
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.632402 -> 0.2.632503)
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.632503 -> 0.2.0-preview.25325.106)
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25325.106 -> 0.2.0-preview.25326.109)
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25326.109 -> 0.2.0-preview.25327.102)
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25327.102 -> 0.2.0-preview.25330.103)
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25330.103 -> 0.2.0-preview.25351.105)
@nohwnd
Copy link
Member

nohwnd commented Jul 2, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-maestro bot added 8 commits July 3, 2025 02:06
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25351.105 -> 0.2.0-preview.25351.106)
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25351.106 -> 0.2.0-preview.25358.102)
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25358.102 -> 0.2.0-preview.25359.101)
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25359.101 -> 0.2.0-preview.25360.101)
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25360.101 -> 0.2.0-preview.25362.103)
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25362.103 -> 0.2.0-preview.25363.101)
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25363.101 -> 0.2.0-preview.25364.102)
@nohwnd
Copy link
Member

nohwnd commented Jul 15, 2025

update from dotnet/dotnet updated us to the 0.2.xxx version, and now it is trying to downgrade, did the versioning change and this is now safe to merge @ViktorHofer ?

c049523

Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25364.102 -> 0.2.0-preview.25365.101)
@akoeplinger
Copy link
Member

This was introduced in dotnet/dotnet#1317. I wonder if you should be consuming the package from the dotnet/diagnostics build instead of the VMR build cause it seems you're redistributing it. @mmitche

dotnet-maestro bot added 2 commits July 17, 2025 02:14
Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25365.101 -> 0.2.0-preview.25366.103)
@akoeplinger
Copy link
Member

Dug through some more Teams history and this should be fine precisely because you're only redistributing it inside another package (not as a transitive reference) so the version number doesn't really matter, it's basically just a transport package.

Copy link
Member

@nohwnd nohwnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay to downgrade, per comments above.

@nohwnd nohwnd merged commit c144443 into main Jul 17, 2025
11 of 12 checks passed
@nohwnd nohwnd deleted the darc-main-82558c1b-48b7-453a-88c0-cda8fc1e9b29 branch July 17, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants