Source build SDK layout does not match Microsoft

[MichaelSimons]

In .NET 10 there are differences in the vstest related files contained in the SDK between source-build and the Microsoft build.

The Microsoft build contains the following resource assemblies in sdk/x.y.z/Extensions/ while in source-build these are under sdk/x.y.z/:

Microsoft.TestPlatform.Extensions.BlameDataCollector.resources.dll
Microsoft.TestPlatform.TestHostRuntimeProvider.resources.dll
Microsoft.VisualStudio.TestPlatform.Extensions.Html.TestLogger.resources.dll
Microsoft.VisualStudio.TestPlatform.Extensions.Trx.TestLogger.resources.dll

Additionally the source-build is missing the following assemblies:

Microsoft.TestPlatform.Extensions.BlameDataCollector.dll
Microsoft.TestPlatform.Extensions.EventLogCollector.dll

These changes appear to have been introduced with #4856.

Related to dotnet/source-build#4881.

[MichaelSimons]

cc @Evangelink, @nohwnd

[nohwnd]

Thanks for the heads up, I am currently trying to insert 18.x.x into SDK, once that is done I will look on how to fix this.

[nohwnd]

I am comparing Microsoft.TestPlatform.CLI package that is produced by:

dotnet pack src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj - I assume that is what you call the Microsoft build.

And: dotnet pack src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj /p:DotNetBuildSourceOnly=true /p:DotNetBuildFromVMR=false -tl:false

Which should produce the source build package hopefully.

I do see the differences you mention. But I also see more, is there some exclusion list that I should also take into consideration? E.g
I see dumpMiniTools missing that we recently added to the cli package.

I also don't see the blame missing from the package. The original issue (dotnet/source-build#4881) seems to be from february, so I assume that it is simply outdated.

I will later also look at the package produced with the VMR property set to true.

[nohwnd]

also thanks for the analysis of the problem, that helped immensly.