trx logger does not include Description attribute

[AbhitejJohn]

Description

Test description attributes like Description, CssIteration, WorkItem, CssProjectStructure do not show up in the trx log. Only Owner and Priority are part of the log.

Steps to reproduce

1. Create an MSTest V1 based project.
2. Add a DescriptionAttribute on top of the test method.
3. Run tests with trx turned on.

Expected behavior

The trx should have the description string associated with the test in the log.

Actual behavior

The description string does not show up in the log.

Environment

I'm trying this on Dev15 prev-5 and on Windows 10.

[AbhitejJohn]

Tied to https://github.com/Microsoft/testfx/pull/16

[codito]

Description attribute is very specific to a particular test framework. Should there be a extensibility point for test frameworks contribute data into trx logger?

@Faizan2304 what do you think?

[codito]

@AbhitejJohn is this a regression since Dev14 Update 3?

[AbhitejJohn]

@codito : DescriptionAttribute was just an example. All these do not show up: Description, CssIteration, WorkItem, CssProjectStructure. They however do get filled in properly when run from mstest.exe though.

IMHO all traits that frameworks fill in need to be part of trx. The goal is to not hard code of-course.

This has been the behaviour in TP V1 for a long time though. We only put in Priority and Owner but the drawback for this is with reporting this in VSTS or any place else.

[codito]

@AbhitejJohn makes sense. A sample trx with Priority looks like following:

    <UnitTest name="TestWithPriority" storage="g:\tmp\unittestproject1.dll" priority="0" id="f2daad78-aff7-a545-f0ba-d1d27d5b0789">
      <Execution id="40c5e9e7-9349-4a0e-a885-393691579e2a" />
      <TestMethod codeBase="G:\tmp\UnitTestProject1.dll" executorUriOfAdapter="executor://mstestadapter/v2" className="SampleUnitTestProject.UnitTest1" name="TestWithPriority" />
    </UnitTest>

Would an output like below make sense? Note the Traits section.

    <UnitTest name="TestWithPriority" storage="g:\tmp\unittestproject1.dll" priority="0" id="f2daad78-aff7-a545-f0ba-d1d27d5b0789">
      <Execution id="40c5e9e7-9349-4a0e-a885-393691579e2a" />
      <TestMethod codeBase="G:\tmp\UnitTestProject1.dll" executorUriOfAdapter="executor://mstestadapter/v2" className="SampleUnitTestProject.UnitTest1" name="TestWithPriority" />
       <Traits>
            <Trait Name="Description" Value="Sample description" />
            <Trait Name="ComplexData" Value="{ jsonArray: [ 1, 2, 3] }" />
       </Traits>
    </UnitTest>

@pvlakshm @sbaid what do you think?

[AbhitejJohn]

We would want to figure out a schema that fits in with TRI extensibility as well so that these results show up on VSTS.

[pvlakshm]

Triage: will talk to customers to understand scenario and importance.