Skip to content

Commit 9874fab

Browse files
dongjiangregkh
authored andcommitted
power: supply: Use IRQF_ONESHOT
[ Upstream commit 2469b836fa835c67648acad17d62bc805236a6ea ] Fixes coccicheck error: drivers/power/supply/pm2301_charger.c:1089:7-27: ERROR: drivers/power/supply/lp8788-charger.c:502:8-28: ERROR: drivers/power/supply/tps65217_charger.c:239:8-33: ERROR: drivers/power/supply/tps65090-charger.c:303:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Signed-off-by: dongjian <[email protected]> Signed-off-by: Sebastian Reichel <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent ff6c914 commit 9874fab

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

drivers/power/supply/lp8788-charger.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,7 @@ static int lp8788_set_irqs(struct platform_device *pdev,
532532

533533
ret = request_threaded_irq(virq, NULL,
534534
lp8788_charger_irq_thread,
535-
0, name, pchg);
535+
IRQF_ONESHOT, name, pchg);
536536
if (ret)
537537
break;
538538
}

drivers/power/supply/pm2301_charger.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1098,7 +1098,7 @@ static int pm2xxx_wall_charger_probe(struct i2c_client *i2c_client,
10981098
ret = request_threaded_irq(gpio_to_irq(pm2->pdata->gpio_irq_number),
10991099
NULL,
11001100
pm2xxx_charger_irq[0].isr,
1101-
pm2->pdata->irq_type,
1101+
pm2->pdata->irq_type | IRQF_ONESHOT,
11021102
pm2xxx_charger_irq[0].name, pm2);
11031103

11041104
if (ret != 0) {

drivers/power/supply/tps65090-charger.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ static int tps65090_charger_probe(struct platform_device *pdev)
311311

312312
if (irq != -ENXIO) {
313313
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
314-
tps65090_charger_isr, 0, "tps65090-charger", cdata);
314+
tps65090_charger_isr, IRQF_ONESHOT, "tps65090-charger", cdata);
315315
if (ret) {
316316
dev_err(cdata->dev,
317317
"Unable to register irq %d err %d\n", irq,

drivers/power/supply/tps65217_charger.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ static int tps65217_charger_probe(struct platform_device *pdev)
238238
if (irq != -ENXIO) {
239239
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
240240
tps65217_charger_irq,
241-
0, "tps65217-charger",
241+
IRQF_ONESHOT, "tps65217-charger",
242242
charger);
243243
if (ret) {
244244
dev_err(charger->dev,

0 commit comments

Comments
 (0)