Skip to content

Conversation

@SpadeA-Tang
Copy link
Contributor

@SpadeA-Tang SpadeA-Tang commented Oct 22, 2025

pr: #45041
issue: #45001
ref: #42148

Signed-off-by: SpadeA <[email protected]>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Oct 22, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Oct 22, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

@SpadeA-Tang

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  • build(deps): for dependency updates from Dependabot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot sre-ci-robot added do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager labels Oct 22, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[WARNING] No dependent PR reference found

  • Target branch '2.6' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@SpadeA-Tang SpadeA-Tang changed the title fix done fix: fix alter collection failed for STRUCT sub-fields [2.6] Oct 22, 2025
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Oct 22, 2025
Signed-off-by: SpadeA <[email protected]>
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[WARNING] No dependent PR reference found

  • Target branch '2.6' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.98%. Comparing base (a592cfc) to head (4f0a81c).
⚠️ Report is 3 commits behind head on 2.6.

Files with missing lines Patch % Lines
internal/rootcoord/alter_collection_task.go 0.00% 16 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.6   #45042   +/-   ##
=======================================
  Coverage   76.98%   76.98%           
=======================================
  Files        1826     1826           
  Lines      284160   284168    +8     
=======================================
+ Hits       218751   218759    +8     
+ Misses      58354    58351    -3     
- Partials     7055     7058    +3     
Components Coverage Δ
Client 77.99% <ø> (ø)
Core 84.03% <ø> (+<0.01%) ⬆️
Go 75.05% <0.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/rootcoord/alter_collection_task.go 80.24% <0.00%> (-4.45%) ⬇️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SpadeA-Tang, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[WARNING] No dependent PR reference found

  • Target branch '2.6' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

1 similar comment
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[WARNING] No dependent PR reference found

  • Target branch '2.6' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@SpadeA-Tang
Copy link
Contributor Author

/ci-rerun-ut-integration

@mergify mergify bot added the ci-passed label Oct 23, 2025
@zhagnlu
Copy link
Contributor

zhagnlu commented Oct 23, 2025

/lgtm

@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[WARNING] No dependent PR reference found

  • Target branch '2.6' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@SpadeA-Tang
Copy link
Contributor Author

/set-milestone 2.6.5

@sre-ci-robot sre-ci-robot added this to the 2.6.5 milestone Oct 24, 2025
@sre-ci-robot sre-ci-robot removed the do-not-merge/need-milestone generate by v2-label-manager label Oct 24, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] Set milestone to: 2.6.5

@sre-ci-robot sre-ci-robot removed the do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first label Oct 24, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[SUCCESS] PR #45041 merged to master

Use /refresh-label to update related check and label manually

@sre-ci-robot sre-ci-robot merged commit 974d369 into milvus-io:2.6 Oct 24, 2025
13 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants