Skip to content

Conversation

@chasingegg
Copy link
Contributor

@chasingegg chasingegg commented Oct 23, 2025

issue: #44134 #43908

Also, turn on the MinioChunkManager UT.

Signed-off-by: chasingegg <[email protected]>
@sre-ci-robot sre-ci-robot added area/compilation size/L Denotes a PR that changes 100-499 lines. labels Oct 23, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chasingegg
To complete the pull request process, please assign zhengbuqian after the PR has been reviewed.
You can assign the PR to them by writing /assign @zhengbuqian in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 23, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp

If you have any questions or requests, please contact @zhikunyao.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 72.46377% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.09%. Comparing base (6c34386) to head (d19adc9).
⚠️ Report is 45 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/storage/MinioChunkManager.cpp 69.56% 7 Missing ⚠️
internal/core/src/storage/ChunkManager.cpp 25.00% 6 Missing ⚠️
internal/core/src/storage/MinioChunkManager.h 73.91% 6 Missing ⚠️

❌ Your patch status has failed because the patch coverage (72.46%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #45047      +/-   ##
==========================================
+ Coverage   76.95%   77.09%   +0.13%     
==========================================
  Files        1836     1838       +2     
  Lines      285398   285742     +344     
==========================================
+ Hits       219632   220284     +652     
+ Misses      58561    58243     -318     
- Partials     7205     7215      +10     
Components Coverage Δ
Client 78.03% <ø> (ø)
Core 84.33% <72.46%> (+0.45%) ⬆️
Go 75.07% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
...nternal/core/src/storage/MinioChunkManagerTest.cpp 100.00% <100.00%> (ø)
...ternal/core/src/storage/RemoteChunkManagerTest.cpp 97.28% <100.00%> (ø)
internal/core/src/storage/ChunkManager.cpp 26.25% <25.00%> (+26.25%) ⬆️
internal/core/src/storage/MinioChunkManager.h 52.00% <73.91%> (+52.00%) ⬆️
internal/core/src/storage/MinioChunkManager.cpp 65.77% <69.56%> (+65.77%) ⬆️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: chasingegg <[email protected]>
Signed-off-by: chasingegg <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2025

@chasingegg cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@chasingegg
Copy link
Contributor Author

/run-cpu-e2e

Signed-off-by: chasingegg <[email protected]>
Signed-off-by: chasingegg <[email protected]>
Signed-off-by: chasingegg <[email protected]>
@mergify mergify bot added the ci-passed label Oct 23, 2025
Signed-off-by: chasingegg <[email protected]>
@mergify mergify bot removed the ci-passed label Oct 24, 2025
@chasingegg
Copy link
Contributor Author

/ci-rerun-ut-go

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2025

@chasingegg go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chasingegg
Copy link
Contributor Author

rerun go-sd

@chasingegg
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Oct 24, 2025
@chasingegg
Copy link
Contributor Author

close this one, waiting for storagev2 supporting crt client and storagev2 will not be used anymore

@chasingegg chasingegg closed this Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants