updated the create() func for KBs

Author: MinuraPunchihewa

mindsdb_sdk/knowledge_bases.py

@@ -288,7 +288,8 @@ def get(self, name: str) -> KnowledgeBase:
     def create(
         self,
         name: str,
-        model: Model = None,
+        embedding_model: dict = None,
+        reranking_model: dict = None,
         storage: Table = None,
         metadata_columns: list = None,
         content_columns: list = None,
@@ -301,7 +302,8 @@ def create(
 
         >>> kb = server.knowledge_bases.create(
         ...   'my_kb',
-        ...   model=server.models.emb_model,
+        ...   embedding_model={'provider': 'openai', 'model': 'text-embedding-ada-002', 'api_key': 'sk-...'},
+        ...   reranking_model={'provider': 'openai', 'model': 'gpt-4', 'api_key': 'sk-...'},
         ...   storage=server.databases.pvec.tables.tbl1,
         ...   metadata_columns=['date', 'author'],
         ...   content_columns=['review', 'description'],
@@ -310,7 +312,8 @@ def create(
         ...)
 
         :param name: name of the knowledge base
-        :param model: embedding model, optional. Default: 'sentence_transformers' will be used (defined in mindsdb server)
+        :param embedding_model: embedding model, optional. Default: OpenAI will be the default provider
+        :param reranking_model: reranking model, optional. Default: OpenAI will be the default provider
         :param storage: vector storage, optional. Default: chromadb database will be created
         :param metadata_columns: columns to use as metadata, optional. Default: all columns which are not content and id
         :param content_columns: columns to use as content, optional. Default: all columns except id column
@@ -319,30 +322,24 @@ def create(
         :return: created KnowledgeBase object
         """
 
-        params_out = {}
-
-        if metadata_columns is not None:
-            params_out['metadata_columns'] = metadata_columns
-
-        if content_columns is not None:
-            params_out['content_columns'] = content_columns
-
-        if id_column is not None:
-            params_out['id_column'] = id_column
-
-        if params is not None:
-            params_out.update(params)
-
-        if model is not None:
-            model = model.name
-
         payload = {
             'name': name,
-            'model': model,
-            'params': params_out
         }
 
-        if storage is not None:
+        if embedding_model:
+            payload['embedding_model'] = embedding_model
+        if reranking_model:
+            payload['reranking_model'] = reranking_model
+        if metadata_columns:
+            payload['metadata_columns'] = metadata_columns
+        if content_columns:
+            payload['content_columns'] = content_columns
+        if id_column:
+            payload['id_column'] = id_column
+        if params:
+            payload['params'] = params
+
+        if storage:
             payload['storage'] = {
                 'database': storage.db.name,
                 'table': storage.name