Remove some noisy logging

Author: mbertrand

learning_resources/etl/utils.py

@@ -457,7 +457,6 @@ def get_url_from_module_id(
         str: The URL for the module
     """
     if not module_id:
-        log.warning("Module ID is empty")
         return None
     root_url = get_root_url_for_source(run.learning_resource.etl_source)
     # OLL needs to have 'course-v1:' added to the run_id
@@ -479,7 +478,6 @@ def get_url_from_module_id(
     elif module_id.startswith("block") and is_valid_uuid(module_id.split("@")[-1]):
         return f"{root_url}/courses/{run_id}/jump_to_id/{module_id.split('@')[-1]}"
     else:
-        log.warning("Unknown module ID format: %s", module_id)
         return None
 
 
@@ -494,7 +492,7 @@ def get_assets_metadata(olx_path: str) -> dict:
         with Path.open(Path(olx_path, "policies/assets.json"), "rb") as f:
             return json.loads(f.read())
     except FileNotFoundError:
-        log.warning("Assets metadata file does not exist: %s", olx_path)
+        log.debug("Assets metadata file does not exist: %s", olx_path)
 
 
 def parse_video_transcripts_xml(
@@ -533,7 +531,7 @@ def get_video_metadata(olx_path: str, run: LearningResourceRun) -> dict:
     video_transcript_mapping = {}
     video_path = Path(olx_path, "video")
     if not video_path.exists():
-        log.warning("No video directory found in OLX path: %s", olx_path)
+        log.debug("No video directory found in OLX path: %s", olx_path)
         return video_transcript_mapping
     for root, _, files in os.walk(str(Path(olx_path, "video"))):
         for filename in files:

learning_resources/etl/utils_test.py

@@ -614,10 +614,7 @@ def test_get_assets_metadata(mocker, tmp_path, assets_exist):
         assert result == assets_data
     else:
         # No assets.json file exists
-        mock_log = mocker.patch("learning_resources.etl.utils.log")
-        result = utils.get_assets_metadata(str(olx_path))
-        assert result is None
-        mock_log.warning.assert_called_once()
+        assert utils.get_assets_metadata(str(olx_path)) is None
 
 
 @pytest.mark.parametrize(
@@ -687,8 +684,6 @@ def test_get_video_metadata(mocker, tmp_path, video_dir_exists):
     olx_path = tmp_path / "course"
     olx_path.mkdir()
 
-    mock_log = mocker.patch("learning_resources.etl.utils.log")
-
     if video_dir_exists:
         video_dir = olx_path / "video"
         video_dir.mkdir()
@@ -720,9 +715,7 @@ def test_get_video_metadata(mocker, tmp_path, video_dir_exists):
         assert call_args[1] == video_xml
     else:
         # No video directory
-        result = utils.get_video_metadata(str(olx_path), run)
-        assert result == {}
-        mock_log.warning.assert_called_once()
+        assert utils.get_video_metadata(str(olx_path), run) == {}
 
 
 @pytest.mark.parametrize(
@@ -798,7 +791,6 @@ def test_get_video_metadata(mocker, tmp_path, video_dir_exists):
     ],
 )
 def test_get_url_from_module_id(  # noqa: PLR0913
-    mocker,
     settings,
     etl_source,
     module_id,
@@ -836,9 +828,6 @@ def test_get_url_from_module_id(  # noqa: PLR0913
         else None
     )
 
-    # Mock log for warning cases
-    mock_log = mocker.patch("learning_resources.etl.utils.log")
-
     result = utils.get_url_from_module_id(
         olx_path, module_id, run, assets_metadata, video_srt_metadata
     )
@@ -847,9 +836,3 @@ def test_get_url_from_module_id(  # noqa: PLR0913
         assert result == expected_url_pattern
     else:
         assert result is None
-        if not module_id:
-            mock_log.warning.assert_any_call("Module ID is empty")
-        elif module_id.endswith(".srt") and not has_video_meta:
-            mock_log.debug.assert_any_call("No video metadata for %s", module_id)
-        elif "unknown-format" in module_id or "invalid-uuid" in module_id:
-            mock_log.warning.assert_any_call("Unknown module ID format: %s", module_id)