Skip to content

Commit 52582db

Browse files
committed
refactor(tpl): prevent calling element.click()
Some legacy browsers do not support HTMLElemnt.click(). Calling element's click handler directly instead.
1 parent 4615b36 commit 52582db

File tree

1 file changed

+26
-20
lines changed

1 file changed

+26
-20
lines changed

src/tpl/frontend/index.js

Lines changed: 26 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111
var Esc = 'Esc';
1212
var Space = ' ';
1313

14+
var noop = function () {
15+
};
16+
1417
var hasClass, addClass, removeClass;
1518
if (document.body.classList) {
1619
hasClass = function (el, className) {
@@ -706,26 +709,8 @@
706709
}, onLacksMkdir);
707710
}
708711

709-
function switchToFileMode() {
710-
if (optFile && optActive !== optFile) {
711-
optFile.focus();
712-
optFile.click();
713-
}
714-
}
715-
716-
function switchToDirMode() {
717-
if (optDirFile) {
718-
if (optActive !== optDirFile) {
719-
optDirFile.focus();
720-
optDirFile.click();
721-
}
722-
} else if (optInnerDirFile) {
723-
if (optActive !== optInnerDirFile) {
724-
optInnerDirFile.focus();
725-
optInnerDirFile.click();
726-
}
727-
}
728-
}
712+
var switchToFileMode = noop;
713+
var switchToDirMode = noop;
729714

730715
function enableAddDirFile() {
731716
var classHidden = 'hidden';
@@ -841,6 +826,27 @@
841826
onClickOptFile(); // prevent clear input files
842827
}
843828
});
829+
830+
switchToFileMode = function () {
831+
if (optFile && optActive !== optFile) {
832+
optFile.focus();
833+
onClickOptFile(true);
834+
}
835+
}
836+
837+
switchToDirMode = function () {
838+
if (optDirFile) {
839+
if (optActive !== optDirFile) {
840+
optDirFile.focus();
841+
onClickOptDirFile();
842+
}
843+
} else if (optInnerDirFile) {
844+
if (optActive !== optInnerDirFile) {
845+
optInnerDirFile.focus();
846+
onClickOptInnerDirFile();
847+
}
848+
}
849+
}
844850
}
845851

846852
function enableUploadProgress() { // also fix Safari upload filename has no path info

0 commit comments

Comments
 (0)