Skip to content

Commit 617af89

Browse files
committed
fix(serverHandler/header): allow output same header name multi times
1 parent 15105d1 commit 617af89

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

src/serverHandler/header.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@ func (h *handler) header(w http.ResponseWriter) {
88
}
99
header := w.Header()
1010
for _, headerPair := range h.globalHeaders {
11-
header.Set(headerPair[0], headerPair[1])
11+
header.Add(headerPair[0], headerPair[1])
1212
}
1313
}

test/case/023.custom.header.bash

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,19 @@
22

33
source "$root"/lib.bash
44

5-
"$ghfs" -l 3003 -r "$fs"/vhost1 --header foo:bar &
5+
"$ghfs" -l 3003 -r "$fs"/vhost1 --header foo:bar --header 'set-cookie:name1=value1' --header 'set-cookie:name2=value2' &
66
sleep 0.05 # wait server ready
77

88
(curl_get_header http://127.0.0.1:3003/ | grep -q -i 'foo:\s*bar') ||
9-
fail "Custom header not exists"
9+
fail "Custom header 'foo:bar' not exists"
1010

1111
(curl_get_header http://127.0.0.1:3003/file1.txt | grep -q -i 'foo:\s*bar') ||
12-
fail "Custom header not exists"
12+
fail "Custom header 'foo:bar' not exists"
13+
14+
(curl_get_header http://127.0.0.1:3003/ | grep -q -i 'set-cookie:\s*name1=value1') ||
15+
fail "Custom header 'set-cookie:name1=value1' not exists"
16+
17+
(curl_get_header http://127.0.0.1:3003/ | grep -q -i 'set-cookie:\s*name2=value2') ||
18+
fail "Custom header 'set-cookie:name2=value2' not exists"
1319

1420
jobs -p | xargs kill

0 commit comments

Comments
 (0)