Skip to content

Commit 9d9b50b

Browse files
committed
Fixing test cases
Signed-off-by: Abhinandan Prativadi <[email protected]>
1 parent 3ca429a commit 9d9b50b

File tree

5 files changed

+11
-7
lines changed

5 files changed

+11
-7
lines changed

api/api_test.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -821,11 +821,15 @@ func TestProcPublishUnpublishService(t *testing.T) {
821821
if err != nil {
822822
t.Fatal(err)
823823
}
824-
si, errRsp := procPublishService(c, vars, b)
824+
sv, errRsp := procPublishService(c, vars, b)
825825
if errRsp != &createdResponse {
826826
t.Fatalf("Unexpected failure: %v", errRsp)
827827
}
828-
sid := i2s(si)
828+
ep, ok := sv.(endpointInfo)
829+
if !ok {
830+
panic(fmt.Sprintf("Failed for %v", sv))
831+
}
832+
sid := ep.ID
829833

830834
vars[urlEpID] = ""
831835
_, errRsp = procUnpublishService(c, vars, nil)

api/types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ type serviceDelete struct {
9696
Force bool `json:"force"`
9797
}
9898

99-
// endpointInfo contants the endpoint info for https response message on endpoint creation
99+
// endpointInfo represents the endpoint info for https response message on endpoint creation
100100
type endpointInfo struct {
101101
ID string `json:"id"`
102102
Address net.IPNet `json:"address"`

client/client_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ var mockContainerID = "2a3456789"
3535
var mockSandboxID = "2b3456789"
3636

3737
func setupMockHTTPCallback() {
38-
var list []networkResource
39-
nw := networkResource{Name: mockNwName, ID: mockNwID}
38+
var list []NetworkResource
39+
nw := NetworkResource{Name: mockNwName, ID: mockNwID}
4040
mockNwJSON, _ = json.Marshal(nw)
4141
list = append(list, nw)
4242
mockNwListJSON, _ = json.Marshal(list)

client/service.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,13 +180,13 @@ func (cli *NetworkCli) CmdServicePublish(chain string, args ...string) error {
180180
return err
181181
}
182182

183-
var ep libnetwork.Endpoint
183+
var ep EndpointInfo
184184
err = json.Unmarshal(obj, &ep)
185185
if err != nil {
186186
return err
187187
}
188188

189-
fmt.Fprintf(cli.out, "%s\n", ep.ID())
189+
fmt.Fprintf(cli.out, "%s\n", ep.ID)
190190
return nil
191191
}
192192

install/cniserver

-18.8 MB
Binary file not shown.

0 commit comments

Comments
 (0)