Check that Placement is not null before trying to access it

sgiacomel · sgiacomel · commit 9cf444418357 · 2020-05-27T08:40:08.000-04:00
Signed-off-by: Simone Giacomel &lt;sgiacomel@medstack.co&gt;
diff --git a/manager/orchestrator/task.go b/manager/orchestrator/task.go
@@ -119,6 +119,10 @@ func nodeMatches(s *api.Service, n *api.Node) bool {
 		return false
 	}
 
+	if s.Spec.Task.Placement == nil {
+		return false
+	}
+
 	constraints, _ := constraint.Parse(s.Spec.Task.Placement.Constraints)
 	return constraint.NodeMatches(constraints, n)
 }

Original file line number	Diff line number	Diff line change
`@@ -119,6 +119,10 @@ func nodeMatches(s api.Service, n api.Node) bool {`
`119`	`119`	`return false`
`120`	`120`	`}`
`121`	`121`
	`122`	`+ if s.Spec.Task.Placement == nil {`
	`123`	`+ return false`
	`124`	`+ }`
	`125`	`+`
`122`	`126`	`constraints, _ := constraint.Parse(s.Spec.Task.Placement.Constraints)`
`123`	`127`	`return constraint.NodeMatches(constraints, n)`
`124`	`128`	`}`