Skip to content

Stop MCP client receive loop from spinning after transport closes #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Stop MCP client receive loop from spinning after transport closes #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Sources/MCP/Client/Client.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ public actor Client {
// Start message handling loop
task = Task {
guard let connection = self.connection else { return }
repeat {
loop: while true {
// Check for cancellation before starting the iteration
if Task.isCancelled { break }

Expand Down Expand Up @@ -207,6 +207,8 @@ public actor Client {
)
}
}
await logger?.debug("Client receive stream finished; exiting loop.")
break loop
} catch let error where MCPError.isResourceTemporarilyUnavailable(error) {
try? await Task.sleep(for: .milliseconds(10))
continue
Expand All @@ -215,7 +217,7 @@ public actor Client {
"Error in message handling loop", metadata: ["error": "\(error)"])
break
}
} while true
}
await self.logger?.debug("Client message handling loop task is terminating.")
}

Expand Down