From 647405d99280e63341714b81ffde8ecf37b8fa27 Mon Sep 17 00:00:00 2001
From: T0RNATO <nlittle315@gmail.com>
Date: Thu, 26 Jun 2025 22:21:44 +1000
Subject: [PATCH] feat(frontend): show already-loaded low-res gallery image
 while full-res image is loading

---
 .../src/pages/[type]/[id]/gallery.vue         | 48 ++++++++++++++-----
 1 file changed, 36 insertions(+), 12 deletions(-)

diff --git a/apps/frontend/src/pages/[type]/[id]/gallery.vue b/apps/frontend/src/pages/[type]/[id]/gallery.vue
index 4f355236ce..c74257d89f 100644
--- a/apps/frontend/src/pages/[type]/[id]/gallery.vue
+++ b/apps/frontend/src/pages/[type]/[id]/gallery.vue
@@ -137,15 +137,18 @@
       <div class="content">
         <img
           class="image"
-          :class="{ 'zoomed-in': zoomedIn }"
-          :src="
-            expandedGalleryItem.raw_url
-              ? expandedGalleryItem.raw_url
-              : 'https://cdn.modrinth.com/placeholder-banner.svg'
-          "
-          :alt="expandedGalleryItem.title ? expandedGalleryItem.title : 'gallery-image'"
+          :class="{ 'zoomed-in': zoomedIn, hidden: expandedGalleryImageLoading }"
+          :src="expandedGalleryItem.raw_url || 'https://cdn.modrinth.com/placeholder-banner.svg'"
+          :alt="expandedGalleryItem.title || 'gallery-image'"
+          @load="expandedGalleryImageLoading = false"
           @click.stop
         />
+        <img
+          v-if="expandedGalleryImageLoading"
+          class="image loading-image"
+          :src="expandedGalleryItem.url || 'https://cdn.modrinth.com/placeholder-banner.svg'"
+          :alt="expandedGalleryItem.title || 'gallery-image'"
+        />
 
         <div class="floating" @click.stop>
           <div class="text">
@@ -165,9 +168,7 @@
                 class="open circle-button"
                 target="_blank"
                 :href="
-                  expandedGalleryItem.raw_url
-                    ? expandedGalleryItem.raw_url
-                    : 'https://cdn.modrinth.com/placeholder-banner.svg'
+                  expandedGalleryItem.raw_url || 'https://cdn.modrinth.com/placeholder-banner.svg'
                 "
               >
                 <ExternalIcon aria-hidden="true" />
@@ -220,8 +221,8 @@
       <div v-for="(item, index) in project.gallery" :key="index" class="card gallery-item">
         <a class="gallery-thumbnail" @click="expandImage(item, index)">
           <img
-            :src="item.url ? item.url : 'https://cdn.modrinth.com/placeholder-banner.svg'"
-            :alt="item.title ? item.title : 'gallery-image'"
+            :src="item.url || 'https://cdn.modrinth.com/placeholder-banner.svg'"
+            :alt="item.title || 'gallery-image'"
           />
         </a>
         <div class="gallery-body">
@@ -339,6 +340,8 @@ export default defineNuxtComponent({
     return {
       expandedGalleryItem: null,
       expandedGalleryIndex: 0,
+      expandedGalleryImageLoading: false,
+      expandedGalleryIndices: [],
       zoomedIn: false,
 
       deleteIndex: -1,
@@ -381,6 +384,10 @@ export default defineNuxtComponent({
         this.expandedGalleryIndex = 0;
       }
       this.expandedGalleryItem = this.project.gallery[this.expandedGalleryIndex];
+      if (!this.expandedGalleryIndices.includes(this.expandedGalleryIndex)) {
+        this.expandedGalleryImageLoading = true;
+        this.expandedGalleryIndices.push(this.expandedGalleryIndex);
+      }
     },
     previousImage() {
       this.expandedGalleryIndex--;
@@ -388,11 +395,19 @@ export default defineNuxtComponent({
         this.expandedGalleryIndex = this.project.gallery.length - 1;
       }
       this.expandedGalleryItem = this.project.gallery[this.expandedGalleryIndex];
+      if (!this.expandedGalleryIndices.includes(this.expandedGalleryIndex)) {
+        this.expandedGalleryImageLoading = true;
+        this.expandedGalleryIndices.push(this.expandedGalleryIndex);
+      }
     },
     expandImage(item, index) {
       this.expandedGalleryItem = item;
       this.expandedGalleryIndex = index;
       this.zoomedIn = false;
+      if (!this.expandedGalleryIndices.includes(index)) {
+        this.expandedGalleryImageLoading = true;
+        this.expandedGalleryIndices.push(index);
+      }
     },
     resetEdit() {
       this.editIndex = -1;
@@ -604,12 +619,21 @@ export default defineNuxtComponent({
       max-height: calc(100vh - 2 * var(--spacing-card-lg));
       border-radius: var(--size-rounded-card);
 
+      &.loading-image {
+        min-width: calc(60vw - 2 * var(--spacing-card-lg));
+        min-height: calc(60vh - 2 * var(--spacing-card-lg));
+      }
+
       &.zoomed-in {
         object-fit: cover;
         width: auto;
         height: calc(100vh - 2 * var(--spacing-card-lg));
         max-width: calc(100vw - 2 * var(--spacing-card-lg));
       }
+
+      &.hidden {
+        display: none;
+      }
     }
     .floating {
       position: absolute;