use methods rather so the timing of keeping these synced is not a thing

Author: lerouxb

packages/collection-model/lib/model.js

@@ -102,7 +102,7 @@ function pickCollectionInfo({
   validation,
   clustered,
   fle2,
-  is_ghost_namespace,
+  inferred_from_privileges,
 }) {
   return {
     type,
@@ -113,7 +113,7 @@ function pickCollectionInfo({
     validation,
     clustered,
     fle2,
-    is_ghost_namespace,
+    inferred_from_privileges,
   };
 }
 
@@ -135,7 +135,7 @@ const CollectionModel = AmpersandModel.extend(debounceActions(['fetch']), {
     statusError: { type: 'string', default: null },
 
     // Normalized values from collectionInfo command
-    is_ghost_namespace: 'boolean',
+    inferred_from_privileges: 'boolean',
     readonly: 'boolean',
     clustered: 'boolean',
     fle2: 'boolean',
@@ -269,7 +269,7 @@ const CollectionModel = AmpersandModel.extend(debounceActions(['fetch']), {
     const shouldFetchDbAndCollStats = getParentByType(
       this,
       'Instance'
-    ).shouldFetchDbAndCollStats;
+    ).shouldFetchDbAndCollStats();
 
     try {
       const newStatus = this.status === 'initial' ? 'fetching' : 'refreshing';
@@ -286,14 +286,14 @@ const CollectionModel = AmpersandModel.extend(debounceActions(['fetch']), {
         ...collStats,
         ...(collectionInfo && pickCollectionInfo(collectionInfo)),
       });
-      // If the collection is not unprovisioned `is_ghost_namespace` anymore,
+      // If the collection is not unprovisioned `inferred_from_privileges` anymore,
       // let's update the parent database model to reflect the change.
       // This happens when a user tries to insert first document into a
       // collection that doesn't exist yet or creates a new collection
       // for an unprovisioned database.
-      if (!this.is_ghost_namespace) {
+      if (!this.inferred_from_privileges) {
         getParentByType(this, 'Database').set({
-          is_ghost_namespace: false,
+          inferred_from_privileges: false,
         });
       }
     } catch (err) {
@@ -388,7 +388,7 @@ const CollectionCollection = AmpersandCollection.extend(
       const shouldFetchNamespacesFromPrivileges = getParentByType(
         this,
         'Instance'
-      ).shouldFetchNamespacesFromPrivileges;
+      ).shouldFetchNamespacesFromPrivileges();
 
       if (!databaseName) {
         throw new Error(

packages/compass-app-stores/src/stores/instance-store.ts

@@ -290,7 +290,6 @@ export function createInstancesStore(
     const connectedConnectionIds = Array.from(
       instancesManager.listMongoDBInstances().keys()
     );
-
     for (const connectionId of connectedConnectionIds) {
       void refreshDatabases({ connectionId });
     }

packages/database-model/lib/model.js

@@ -105,7 +105,7 @@ const DatabaseModel = AmpersandModel.extend(
       statusError: { type: 'string', default: null },
       collectionsStatus: { type: 'string', default: 'initial' },
       collectionsStatusError: { type: 'string', default: null },
-      is_ghost_namespace: 'boolean',
+      inferred_from_privileges: 'boolean',
       collection_count: 'number',
       document_count: 'number',
       storage_size: 'number',
@@ -142,7 +142,7 @@ const DatabaseModel = AmpersandModel.extend(
       const shouldFetchDbAndCollStats = getParentByType(
         this,
         'Instance'
-      ).shouldFetchDbAndCollStats;
+      ).shouldFetchDbAndCollStats();
 
       if (!shouldFetch(this.status, force)) {
         return;
@@ -252,7 +252,7 @@ const DatabaseCollection = AmpersandCollection.extend(
       }
 
       const shouldFetchNamespacesFromPrivileges =
-        instanceModel.shouldFetchNamespacesFromPrivileges;
+        instanceModel.shouldFetchNamespacesFromPrivileges();
 
       const dbs = await dataService.listDatabases({
         nameOnly: true,
@@ -262,10 +262,10 @@ const DatabaseCollection = AmpersandCollection.extend(
       });
 
       this.set(
-        dbs.map(({ _id, name, is_ghost_namespace }) => ({
+        dbs.map(({ _id, name, inferred_from_privileges }) => ({
           _id,
           name,
-          is_ghost_namespace,
+          inferred_from_privileges,
         }))
       );
     },

packages/instance-model/lib/model.js

@@ -135,33 +135,9 @@ const InstanceModel = AmpersandModel.extend(
       isSearchIndexesSupported: 'boolean',
       atlasVersion: { type: 'string', default: '' },
       csfleMode: { type: 'string', default: 'unavailable' },
-      shouldFetchDbAndCollStats: { type: 'boolean', default: false },
-      shouldFetchNamespacesFromPrivileges: { type: 'boolean', default: true },
     },
     initialize: function ({ preferences, ...props }) {
-      // Initialize the property directly from preferences
-      this.set({
-        shouldFetchDbAndCollStats:
-          preferences.getPreferences().enableDbAndCollStats,
-        shouldFetchNamespacesFromPrivileges:
-          preferences.getPreferences().inferNamespacesFromPrivileges,
-      });
-
-      // Listen to preference changes using the preferences API
-      this._enableDbAndCollStatsUnsubscribe =
-        preferences.onPreferenceValueChanged(
-          'enableDbAndCollStats',
-          (value) => {
-            this.set({ shouldFetchDbAndCollStats: value });
-          }
-        );
-      this._inferNamespacesFromPrivilegesUnsubscribe =
-        preferences.onPreferenceValueChanged(
-          'inferNamespacesFromPrivileges',
-          (value) => {
-            this.set({ shouldFetchNamespacesFromPrivileges: value });
-          }
-        );
+      this.preferences = preferences;
 
       AmpersandModel.prototype.initialize.call(this, props);
     },
@@ -420,14 +396,15 @@ const InstanceModel = AmpersandModel.extend(
       return coll;
     },
 
+    shouldFetchDbAndCollStats() {
+      return this.preferences.getPreferences().enableDbAndCollStats;
+    },
+
+    shouldFetchNamespacesFromPrivileges() {
+      return this.preferences.getPreferences().inferNamespacesFromPrivileges;
+    },
+
     removeAllListeners() {
-      // Clean up preference listeners
-      if (this._enableDbAndCollStatsUnsubscribe) {
-        this._enableDbAndCollStatsUnsubscribe();
-      }
-      if (this._inferNamespacesFromPrivilegesUnsubscribe) {
-        this._inferNamespacesFromPrivilegesUnsubscribe();
-      }
       InstanceModel.removeAllListeners(this);
     },