Conversation
Anemy
added
release notes
no-title-validation
Anemy
commented
May 19, 2025
| type: query.type === 'recent' ? 'query-history' : 'favorite', | ||
| detail: formatDate(query.lastExecuted.getTime()), | ||
| info: () => createInfo(query, theme).dom, | ||
| info: () => |
Member
Author
There was a problem hiding this comment.
We could give a react tree here somehow.
Member
Author
|
Closing as this is stale and I haven't found time to fix it yet. There's that code mirror race condition edit change that I don't think is easily caught, although there is likely a workaround we can do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened as a draft since we're getting this error when deleting:
Things work as expected, it's likely a race condition in updating the auto completion items and destroying the old info. If we delete it ourselves however, it closes the autocompletion, so maybe there's a way to avoid this I haven't found yet.