fix features.supports_queryable_encryption tests

Author: timgraham

django_mongodb_backend/features.py

@@ -625,16 +625,14 @@ def _supports_transactions(self):
     @cached_property
     def supports_queryable_encryption(self):
         """
-        Queryable Encryption is supported if the server is Atlas or Enterprise
-        and is configured as a replica set or a sharded cluster.
+        Queryable Encryption requires a MongoDB 7.0 or later replica set or sharded
+        cluster, as well as MonogDB Atlas or Enterprise.
         """
         self.connection.ensure_connection()
-        client = self.connection.connection.admin
-        build_info = client.command("buildInfo")
+        build_info = self.connection.connection.admin.command("buildInfo")
         is_enterprise = "enterprise" in build_info.get("modules")
-        # Queryable Encryption requires transaction support which
-        # is only available on replica sets or sharded clusters
-        # which we already check in `supports_transactions`.
-        supports_transactions = self.supports_transactions
-        # TODO: check if the server is Atlas
-        return is_enterprise and supports_transactions and self.is_mongodb_7_0
+        return (
+            (is_enterprise or self.supports_atlas_search)
+            and self._supports_transactions
+            and self.is_mongodb_7_0
+        )

tests/backend_/test_features.py

@@ -45,20 +45,82 @@ def mocked_command(command):
         with patch("pymongo.synchronous.database.Database.command", wraps=mocked_command):
             self.assertIs(connection.features._supports_transactions, False)
 
-# FIXME: On evergreen (again).
-# class SupportsQueryableEncryptionTests(TestCase):
-#     def setUp(self):
-#         # Clear the cached property.
-#         connection.features.__dict__.pop("supports_queryable_encryption", None)
-#
-#     def tearDown(self):
-#         del connection.features.supports_queryable_encryption
-#
-#     def test_supports_queryable_encryption(self):
-#         def mocked_command(command):
-#             if command == "buildInfo":
-#                 return {"modules": ["enterprise"]}
-#             raise Exception("Unexpected command")
-#
-#         with patch("pymongo.synchronous.database.Database.command", wraps=mocked_command):
-#             self.assertIs(connection.features.supports_queryable_encryption, True)
+
+class SupportsQueryableEncryptionTests(TestCase):
+    def setUp(self):
+        # Clear the cached property.
+        connection.features.__dict__.pop("supports_queryable_encryption", None)
+        # Must initialize the feature before patching it.
+        connection.features._supports_transactions  # noqa: B018
+
+    def tearDown(self):
+        del connection.features.supports_queryable_encryption
+
+    @staticmethod
+    def enterprise_response(command):
+        if command == "buildInfo":
+            return {"modules": ["enterprise"]}
+        raise Exception("Unexpected command")
+
+    @staticmethod
+    def non_enterprise_response(command):
+        if command == "buildInfo":
+            return {"modules": []}
+        raise Exception("Unexpected command")
+
+    def test_supported_on_atlas(self):
+        """Supported on MongoDB 7.0+ Atlas replica set or sharded cluster."""
+        with (
+            patch(
+                "pymongo.synchronous.database.Database.command", wraps=self.non_enterprise_response
+            ),
+            patch("django.db.connection.features.supports_atlas_search", True),
+            patch("django.db.connection.features._supports_transactions", True),
+            patch("django.db.connection.features.is_mongodb_7_0", True),
+        ):
+            self.assertIs(connection.features.supports_queryable_encryption, True)
+
+    def test_supported_on_enterprise(self):
+        """Supported on MongoDB 7.0+ Enterprise replica set or sharded cluster."""
+        with (
+            patch("pymongo.synchronous.database.Database.command", wraps=self.enterprise_response),
+            patch("django.db.connection.features.supports_atlas_search", False),
+            patch("django.db.connection.features._supports_transactions", True),
+            patch("django.db.connection.features.is_mongodb_7_0", True),
+        ):
+            self.assertIs(connection.features.supports_queryable_encryption, True)
+
+    def test_atlas_or_enterprise_required(self):
+        """Not supported on MongoDB Community Edition."""
+        with (
+            patch(
+                "pymongo.synchronous.database.Database.command", wraps=self.non_enterprise_response
+            ),
+            patch("django.db.connection.features.supports_atlas_search", False),
+            patch("django.db.connection.features._supports_transactions", True),
+            patch("django.db.connection.features.is_mongodb_7_0", True),
+        ):
+            self.assertIs(connection.features.supports_queryable_encryption, True)
+
+    def test_transactions_required(self):
+        """
+        Not supported if database isn't a replica set or sharded cluster
+        (i.e. DatabaseFeatures._supports_transactions = False).
+        """
+        with (
+            patch("pymongo.synchronous.database.Database.command", wraps=self.enterprise_response),
+            patch("django.db.connection.features.supports_atlas_search", False),
+            patch("django.db.connection.features._supports_transactions", False),
+            patch("django.db.connection.features.is_mongodb_7_0", True),
+        ):
+            self.assertIs(connection.features.supports_queryable_encryption, False)
+
+    def test_mongodb_7_0_required(self):
+        """Not supported on MongoDB < 7.0"""
+        with (
+            patch("pymongo.synchronous.database.Database.command", wraps=self.enterprise_response),
+            patch("django.db.connection.features.supports_atlas_search", False),
+            patch("django.db.connection.features._supports_transactions", True),
+            patch("django.db.connection.features.is_mongodb_7_0", False),
+        ):
+            self.assertIs(connection.features.supports_queryable_encryption, False)