-
Notifications
You must be signed in to change notification settings - Fork 10
DOCSP-51321: Configure CRUD operations #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: comp-cov
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docs-kotlin-sync ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🔄 Deploy Preview for docs-kotlin-sync processing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ some small suggestions
secondary replica set members. | ||
- ``LOCAL`` read concern: Read operations return the instance's most recent data | ||
without guaranteeing that the data has been written to a majority of the replica | ||
set members. | ||
- ``W2`` write concern: The primary replica set member and one secondary member | ||
must acknowledge the write operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No periods needed
- ``secondary`` read preference: Read operations retrieve data from | |
secondary replica set members. | |
- ``LOCAL`` read concern: Read operations return the instance's most recent data | |
without guaranteeing that the data has been written to a majority of the replica | |
set members. | |
- ``W2`` write concern: The primary replica set member and one secondary member | |
must acknowledge the write operation. | |
- ``secondary`` read preference: Read operations retrieve data from | |
secondary replica set members | |
- ``LOCAL`` read concern: Read operations return the instance's most recent data | |
without guaranteeing that the data has been written to a majority of the replica | |
set members | |
- ``W2`` write concern: The primary replica set member and one secondary member | |
must acknowledge the write operation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think since these are full sentences, they should have periods - https://www.mongodb.com/docs/meta/style-guide/style/lists/#list-items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call
the primary replica set member. | ||
- ``MAJORITY`` read concern: Read operations return the instance's most recent data | ||
that has been written to a majority of replica set members. | ||
- ``W1`` write concern: The primary replica set member must acknowledge the | ||
write operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No periods needed
- ``primary`` read preference: Read operations retrieve data from | |
the primary replica set member. | |
- ``MAJORITY`` read concern: Read operations return the instance's most recent data | |
that has been written to a majority of replica set members. | |
- ``W1`` write concern: The primary replica set member must acknowledge the | |
write operation. | |
- ``primary`` read preference: Read operations retrieve data from | |
the primary replica set member | |
- ``MAJORITY`` read concern: Read operations return the instance's most recent data | |
that has been written to a majority of replica set members | |
- ``W1`` write concern: The primary replica set member must acknowledge the | |
write operation |
the primary replica set member, or secondary members if the primary is unavailable. | ||
- ``AVAILABLE`` read concern: Read operations return the instance's most recent data | ||
without guaranteeing that the data has been written to a majority of the replica | ||
set members. | ||
- ``MAJORITY`` write concern: The majority of all replica set members | ||
must acknowledge the write operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No periods needed
- ``primaryPreferred`` read preference: Read operations retrieve data from | |
the primary replica set member, or secondary members if the primary is unavailable. | |
- ``AVAILABLE`` read concern: Read operations return the instance's most recent data | |
without guaranteeing that the data has been written to a majority of the replica | |
set members. | |
- ``MAJORITY`` write concern: The majority of all replica set members | |
must acknowledge the write operation. | |
- ``primaryPreferred`` read preference: Read operations retrieve data from | |
the primary replica set member, or secondary members if the primary is unavailable | |
- ``AVAILABLE`` read concern: Read operations return the instance's most recent data | |
without guaranteeing that the data has been written to a majority of the replica | |
set members | |
- ``MAJORITY`` write concern: The majority of all replica set members | |
must acknowledge the write operation |
secondary replica set members, or the primary members if no secondary members are | ||
available. | ||
- ``AVAILABLE`` read concern: Read operations return the instance's most recent data | ||
without guaranteeing that the data has been written to a majority of the replica | ||
set members. | ||
- ``UNACKNOWLEDGED`` write concern: Replica set members do not need to acknowledge | ||
the write operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ``secondaryPreferred`` read preference: Read operations retrieve data from | |
secondary replica set members, or the primary members if no secondary members are | |
available. | |
- ``AVAILABLE`` read concern: Read operations return the instance's most recent data | |
without guaranteeing that the data has been written to a majority of the replica | |
set members. | |
- ``UNACKNOWLEDGED`` write concern: Replica set members do not need to acknowledge | |
the write operation. | |
- ``secondaryPreferred`` read preference: Read operations retrieve data from | |
secondary replica set members, or the primary members if no secondary members are | |
available | |
- ``AVAILABLE`` read concern: Read operations return the instance's most recent data | |
without guaranteeing that the data has been written to a majority of the replica | |
set members | |
- ``UNACKNOWLEDGED`` write concern: Replica set members do not need to acknowledge | |
the write operation |
- **Mongos**: A query router that provides an interface between your | ||
application and the sharded cluster. | ||
- **Config servers**: Servers that store the cluster's configuration settings | ||
and metadata. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- **Shard**: A replica set that contains a subset of the sharded data. | |
- **Mongos**: A query router that provides an interface between your | |
application and the sharded cluster. | |
- **Config servers**: Servers that store the cluster's configuration settings | |
and metadata. | |
- **Shard**: A replica set that contains a subset of the sharded data | |
- **Mongos**: A query router that provides an interface between your | |
application and the sharded cluster | |
- **Config servers**: Servers that store the cluster's configuration settings | |
and metadata |
source/crud/configure.txt
Outdated
any one server and ensures optimal performance. | ||
|
||
When connecting to a sharded cluster, the {+driver-short+} determines the closest mongos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When connecting to a sharded cluster, the {+driver-short+} determines the closest mongos | |
When connecting to a sharded cluster, the {+driver-short+} determines the closest ``mongos`` |
source/crud/configure.txt
Outdated
When connecting to a sharded cluster, the {+driver-short+} determines the closest mongos | ||
instance by calculating which one has the lowest network round-trip time. Then, the driver | ||
determines the latency window by adding this mongos's average round-trip time to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
determines the latency window by adding this mongos's average round-trip time to the | |
determines the latency window by adding this ``mongos``'s average round-trip time to the |
source/crud/configure.txt
Outdated
determines the latency window by adding this mongos's average round-trip time to the | ||
:ref:`localThresholdMS value <kotlin-sync-local-threshold>`. The driver load balances requests | ||
across up to two random mongos instances that fall within the latency window. For each request, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
across up to two random mongos instances that fall within the latency window. For each request, | |
across up to two random ``mongos`` instances that fall within the latency window. For each request, |
source/crud/configure.txt
Outdated
that are eligible to receive read and write requests. | ||
|
||
By default, the driver uses only mongos instances or replica set members whose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, the driver uses only mongos instances or replica set members whose | |
By default, the driver uses only ``mongos`` instances or replica set members whose |
source/crud/configure.txt
Outdated
.. note:: | ||
|
||
When selecting replica set members from a single mongos instance, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When selecting replica set members from a single mongos instance, the | |
When selecting replica set members from a single ``mongos`` instance, the |
Pull Request Info
PR Reviewing Guidelines
Note to reviewers: this page is very similar to the corresponding Java Sync page, which was approved by writing & dbx: mongodb/docs-java#649
JIRA - https://jira.mongodb.org/browse/DOCSP-51321
Staging Links
Self-Review Checklist