Skip to content

DOCSP-51347: Server Selection #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: comp-cov
Choose a base branch
from
Open

DOCSP-51347: Server Selection #118

wants to merge 3 commits into from

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Jul 17, 2025 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-51347

Staging Links

  • connect/connection-options/server-selection
  • connect/connection-options

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    @netlify Netlify
    Copy link

    netlify bot commented Jul 17, 2025 •
    edited
    Loading

    ✅ Deploy Preview for docs-kotlin-sync ready!

    Name Link
    🔨 Latest commit c3d9175
    🔍 Latest deploy log https://app.netlify.com/projects/docs-kotlin-sync/deploys/687a462cb258360008b62553
    😎 Deploy Preview https://deploy-preview-118--docs-kotlin-sync.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    @docs-builder-bot
    Copy link

    docs-builder-bot commented Jul 17, 2025 •
    edited
    Loading

    🔄 Deploy Preview for docs-kotlin-sync processing

    Item Details
    🔨 Latest Commit 449e98aade256d79e5d6770bc96b2313234aba6b
    😎 Deploy Preview https://deploy-preview-118--docs-kotlin-sync.netlify.app
    🔍 Build Logs View Logs

    shuangela
    shuangela approved these changes Jul 17, 2025
    View reviewed changes
    Copy link
    Collaborator

    @shuangela shuangela left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm % nits

    source/connect/connection-options/server-selection.txt Outdated
    :start-after: // start-custom-selector
    :end-before: // end-custom-selector

    You can then pass an instance of this class to your ``MongoClientSettings`` object by
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    You can then pass an instance of this class to your ``MongoClientSettings`` object by
    Use the ``applyToClustersSettings()`` method to pass an instance of this class to your ``MongoClientSettings`` object

    @mcmorisi mcmorisi marked this pull request as ready for review July 18, 2025 13:03
    @mcmorisi mcmorisi requested a review from a team as a code owner July 18, 2025 13:03
    @mcmorisi mcmorisi requested review from stIncMale and removed request for a team July 18, 2025 13:03
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @shuangela shuangela shuangela approved these changes

    @stIncMale stIncMale Awaiting requested review from stIncMale stIncMale is a code owner automatically assigned from mongodb/dbx-java

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @mcmorisi @docs-builder-bot @shuangela