Skip to content

DOCSP-51325: Connection pools #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: comp-cov
Choose a base branch
from
Open

DOCSP-51325: Connection pools #119

wants to merge 8 commits into from

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented Jul 17, 2025 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-51325

Staging Links

  • connect/connection-options/connection-pools
  • connect/connection-options

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    @netlify Netlify
    Copy link

    netlify bot commented Jul 17, 2025 •
    edited
    Loading

    ✅ Deploy Preview for docs-kotlin-sync ready!

    Name Link
    🔨 Latest commit 0bf8f41
    🔍 Latest deploy log https://app.netlify.com/projects/docs-kotlin-sync/deploys/687950fe92bb9c000816bbab
    😎 Deploy Preview https://deploy-preview-119--docs-kotlin-sync.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    @docs-builder-bot
    Copy link

    docs-builder-bot commented Jul 17, 2025 •
    edited
    Loading

    🔄 Deploy Preview for docs-kotlin-sync processing

    Item Details
    🔨 Latest Commit 1420a5d62415497e84d9cf4039a14423848529b1
    😎 Deploy Preview https://deploy-preview-119--docs-kotlin-sync.netlify.app
    🔍 Build Logs View Logs

    mcmorisi
    mcmorisi approved these changes Jul 17, 2025
    View reviewed changes
    Copy link
    Collaborator

    @mcmorisi mcmorisi left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM with a quick comment on file structure!

    source/connect/connection-pools.txt Outdated
    @@ -10,7 +10,212 @@ Connection Pools
    :depth: 2
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Make sure your comp-cov branch is up to date before merging, as this file should be moved to source/connect/connection-options/connection-pools.txt with the other cxn option subpages

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Ok moved!

    @norareidy norareidy marked this pull request as ready for review July 17, 2025 19:38
    @norareidy norareidy requested a review from a team as a code owner July 17, 2025 19:38
    @norareidy norareidy requested review from katcharov and removed request for a team July 17, 2025 19:38
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @mcmorisi mcmorisi mcmorisi approved these changes

    @katcharov katcharov Awaiting requested review from katcharov katcharov is a code owner automatically assigned from mongodb/dbx-java

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @norareidy @docs-builder-bot @mcmorisi